Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump clouddrove/cloudtrail/aws from 1.4.1 to 1.4.2 #35

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 27, 2024

Bumps clouddrove/cloudtrail/aws from 1.4.1 to 1.4.2.

Release notes

Sourced from clouddrove/cloudtrail/aws's releases.

1.4.2

📝 Documentation Changes

Changelog

Sourced from clouddrove/cloudtrail/aws's changelog.

[1.4.2] - 2024-05-23

📝 Documentation Changes

Commits
  • 29c8e27 Only format cloud watch logs group ARN if the value is not an empty string (#31)
  • 6fc2afe docs: update CHANGELOG.md for 1.4.1
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [clouddrove/cloudtrail/aws](https://github.com/clouddrove/terraform-aws-cloudtrail) from 1.4.1 to 1.4.2.
- [Release notes](https://github.com/clouddrove/terraform-aws-cloudtrail/releases)
- [Changelog](https://github.com/clouddrove/terraform-aws-cloudtrail/blob/master/CHANGELOG.md)
- [Commits](clouddrove/terraform-aws-cloudtrail@1.4.1...1.4.2)

---
updated-dependencies:
- dependency-name: clouddrove/cloudtrail/aws
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file terraform Pull requests that update Terraform code labels May 27, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github May 27, 2024

Dependabot tried to add @approvers as a reviewer to this PR, but received the following error from GitHub:

POST https://api.github.com/repos/clouddrove/terraform-aws-cloudtrail-baseline/pulls/35/requested_reviewers: 422 - Reviews may only be requested from collaborators. One or more of the users or teams you specified is not a collaborator of the clouddrove/terraform-aws-cloudtrail-baseline repository. // See: https://docs.github.com/rest/pulls/review-requests#request-reviewers-for-a-pull-request

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@anmolnagpal
Copy link
Contributor

Terraform Security Scan Failed

Show Output
Result #1 LOW Log group is not encrypted. 
────────────────────────────────────────────────────────────────────────────────
  main.tf:55-60
────────────────────────────────────────────────────────────────────────────────
   55    resource "aws_cloudwatch_log_group" "cloudtrail_events" {
   56      count             = var.enabled ? 1 : 0
   57      name              = var.cloudwatch_logs_group_name
   58      retention_in_days = var.cloudwatch_logs_retention_in_days
   59      tags              = module.labels.tags
   60    }
────────────────────────────────────────────────────────────────────────────────
          ID aws-cloudwatch-log-group-customer-key
      Impact Log data may be leaked if the logs are compromised. No auditing of who have viewed the logs.
  Resolution Enable CMK encryption of CloudWatch Log Groups

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/aws/cloudwatch/log-group-customer-key/
  - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cloudwatch_log_group#kms_key_id
────────────────────────────────────────────────────────────────────────────────


  timings
  ──────────────────────────────────────────
  disk i/o             86.5µs
  parsing              141.201707ms
  adaptation           160.099µs
  checks               3.645046ms
  total                145.093352ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     52
  files read           4

  results
  ──────────────────────────────────────────
  passed               0
  ignored              0
  critical             0
  high                 0
  medium               0
  low                  1

  1 potential problem(s) detected.

@clouddrove-ci clouddrove-ci merged commit 8e4cb44 into master Jul 2, 2024
21 checks passed
@dependabot dependabot bot deleted the dependabot/terraform/clouddrove/cloudtrail/aws-1.4.2 branch July 2, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file terraform Pull requests that update Terraform code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants