Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alarm naming convention to use aws-labels #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ammaan123
Copy link

Before

Earlier the CloudWatch Alarm was being created with name passed in alarm_name variable instead of aws-labels we are using.

resource "aws_cloudwatch_metric_alarm" "..." {
  ...
  alarm_name                = var.alarm_name
  ...
}

Now

Now the CloudWatch Alarm is getting created with namm according to the name, environment & label_order labels.

resource "aws_cloudwatch_metric_alarm" "..." {
  ...
  alarm_name                = module.labels.id 
  ...

@clouddrove-ci
Copy link
Member

Terraform Security Scan Failed

Show Output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants