Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 🐛 Updated naming convention for IAM Policy and IAM Role #31

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

nileshgadgi
Copy link
Contributor

what

  • Update naming format for policy and IAM by default.

why

  • Was having issue due to long naming in several addons.

@nileshgadgi nileshgadgi added the bug Something isn't working label Sep 27, 2023
@nileshgadgi nileshgadgi self-assigned this Sep 27, 2023
@nileshgadgi nileshgadgi changed the title Fix: 🐛 Update naming conevension for policy and IAM name Fix: 🐛 Update naming convension for addons Sep 27, 2023
@nileshgadgi nileshgadgi changed the title Fix: 🐛 Update naming convension for addons Fix: 🐛 Update naming convension for policy and IAM Name Sep 27, 2023
@nileshgadgi nileshgadgi changed the title Fix: 🐛 Update naming convension for policy and IAM Name Fix: 🐛 Updated naming convention for IAM Policy and IAM Role Sep 27, 2023
…ns into feat/naming
Copy link
Member

@h1manshu98 h1manshu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@anmolnagpal anmolnagpal merged commit faeb310 into master Sep 27, 2023
11 checks passed
@anmolnagpal anmolnagpal deleted the feat/naming branch September 27, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants