Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: 🚀 use external-secret in multiple namespaces #33

Merged
merged 6 commits into from
Oct 3, 2023

Conversation

h1manshu98
Copy link
Member

@h1manshu98 h1manshu98 commented Sep 29, 2023

What

  • Updated istio-ingress addon to use Internet-facing and Internal ingresses.
  • Added feature to use externalSecret in other namespaces.
  • To do so User need to create an TrustRelationship policy where user will pass information of other namespace.
  • Then in their application's service-account.yaml, user have to pass IAMRole annotation as below -
apiVersion: v1
kind: ServiceAccount
metadata:
  name: 
  annotations:
    eks.amazonaws.com/role-arn: "arn:aws:iam::12345678912:role/external-secrets-CLUSTER_NAME"

Why

  • Previously we were only able to use external-secret in the namespace where this addon is deployed [kube-system].
  • To use this external-secret in different namespace-X we had to create a ServiceAccount in namespace-X with AWSSecretManager permission.

@h1manshu98 h1manshu98 changed the title feat: use external-secret in multiple namespaces Feat: 🚀 use external-secret in multiple namespaces Oct 2, 2023
nileshgadgi
nileshgadgi previously approved these changes Oct 3, 2023
Copy link
Contributor

@nileshgadgi nileshgadgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

_examples/complete/main.tf Outdated Show resolved Hide resolved
_examples/complete/providers.tf Outdated Show resolved Hide resolved
addons/external-secrets/variables.tf Outdated Show resolved Hide resolved
Copy link
Member

@themaniskshah themaniskshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@anmolnagpal anmolnagpal enabled auto-merge (squash) October 3, 2023 19:50
@anmolnagpal anmolnagpal merged commit c549c3a into master Oct 3, 2023
11 checks passed
@anmolnagpal anmolnagpal deleted the feat/external-secrets_multi-namespace branch October 3, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants