Skip to content

Conversation

mamrajyadav
Copy link
Contributor

what

  • update terraform and aws latest version.
  • update and add github action files.
  • update latest readme.
  • fix tfsec and tflint warnings and removed unnecessary variables.
  • update examples.
  • update main.tf

@clouddrove-ci clouddrove-ci self-assigned this Oct 20, 2023
@clouddrove-ci
Copy link
Member

Terraform Security Scan Failed

Show Output
Result #1 LOW Function does not have tracing enabled. 
────────────────────────────────────────────────────────────────────────────────
  main.tf:36-129
────────────────────────────────────────────────────────────────────────────────
   36resource "aws_lambda_function" "default" {
   37count                          = var.enable ? 1 : 0
   38function_name                  = module.labels.id
   39description                    = var.description
   40role                           = var.create_iam_role ? join("", aws_iam_role.default[*].arn) : var.iam_role_arn
   41handler                        = var.handler
   42memory_size                    = var.memory_size
   43reserved_concurrent_executions = var.reserved_concurrent_executions
   44runtime                        = var.runtime
   ..  
────────────────────────────────────────────────────────────────────────────────
          ID aws-lambda-enable-tracing
      Impact Without full tracing enabled it is difficult to trace the flow of logs
  Resolution Enable tracing

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/aws/lambda/enable-tracing/
  - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lambda_function#mode
────────────────────────────────────────────────────────────────────────────────


  timings
  ──────────────────────────────────────────
  disk i/o             129.9µs
  parsing              75.447637ms
  adaptation           243.301µs
  checks               12.289755ms
  total                88.110593ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     94
  files read           4

  results
  ──────────────────────────────────────────
  passed               3
  ignored              0
  critical             0
  high                 0
  medium               0
  low                  1

  3 passed, 1 potential problem(s) detected.

Copy link

@omsharma07 omsharma07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@omsharma07 omsharma07 merged commit 8b4a549 into master Oct 27, 2023
@delete-merged-branch delete-merged-branch bot deleted the feat/issue_276_a branch October 27, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants