Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: 🚀 Feature all used policies type for Route53 Records. #12

Merged
merged 6 commits into from
Sep 26, 2023
Merged

Feat: 🚀 Feature all used policies type for Route53 Records. #12

merged 6 commits into from
Sep 26, 2023

Conversation

nileshgadgi
Copy link
Contributor

what

  • Feature different policies for Route53 records.
  • Removed unnecessary variables to make code more clean.

why

  • To enhance the module.

references

@nileshgadgi nileshgadgi added bug Something isn't working enhancement New feature or request labels Sep 21, 2023
@nileshgadgi nileshgadgi requested a review from a team September 21, 2023 18:38
@nileshgadgi nileshgadgi self-assigned this Sep 21, 2023
@nileshgadgi nileshgadgi changed the title Feat/weighted Feat: 🚀 Feature all used policies type for Route53 Records. Sep 21, 2023
nikitadugar
nikitadugar approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@nikitadugar nikitadugar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!LGTM

d4kverma
d4kverma approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@d4kverma d4kverma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@themaniskshah themaniskshah merged commit c066541 into master Sep 26, 2023
@delete-merged-branch delete-merged-branch bot deleted the feat/weighted branch September 26, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikitadugar nikitadugar nikitadugar approved these changes

@themaniskshah themaniskshah themaniskshah approved these changes

@d4kverma d4kverma d4kverma approved these changes

@anmolnagpal anmolnagpal Awaiting requested review from anmolnagpal anmolnagpal is a code owner

@clouddrove-ci clouddrove-ci Awaiting requested review from clouddrove-ci clouddrove-ci is a code owner

Assignees

@nileshgadgi nileshgadgi

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nileshgadgi @nikitadugar @themaniskshah @d4kverma @anmolnagpal