Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update workfflows and readme.yaml #53

Merged
merged 4 commits into from
Jun 30, 2023
Merged

feat: update workfflows and readme.yaml #53

merged 4 commits into from
Jun 30, 2023

Conversation

theprashantyadav
Copy link
Contributor

what

  • update redme.yaml and added tflint.yml
  • added CHANGELOG.md file
  • added .editorconfig

why

  • need to update github action
  • need to update readme.yaml

@clouddrove-ci clouddrove-ci self-assigned this Jun 28, 2023
@clouddrove-ci
Copy link
Member

Terraform Security Scan Failed

Show Output
Result #1 MEDIUM VPC Flow Logs is not enabled for VPC  
────────────────────────────────────────────────────────────────────────────────
  main.tf:27-51
────────────────────────────────────────────────────────────────────────────────
   27resource "aws_vpc" "default" {
   28count = var.vpc_enabled ? 1 : 0
   2930cidr_block                           = var.cidr_block
   31ipv4_ipam_pool_id                    = try(var.additional_cidr_block.ipv4_ipam_pool_id, null)
   32ipv4_netmask_length                  = try(var.additional_cidr_block.ipv4_netmask_length, null)
   33ipv6_cidr_block                      = try(var.additional_ipv6_cidr_block.ipv6_cidr_block, null)
   34ipv6_ipam_pool_id                    = try(var.additional_ipv6_cidr_block.ipv6_ipam_pool_id, null)
   35ipv6_netmask_length                  = try(var.additional_ipv6_cidr_block.ipv6_netmask_length, null)
   ..  
────────────────────────────────────────────────────────────────────────────────
          ID aws-ec2-require-vpc-flow-logs-for-all-vpcs
      Impact Without VPC flow logs, you risk not having enough information about network traffic flow to investigate incidents or identify security issues.
  Resolution Enable flow logs for VPC

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/aws/ec2/require-vpc-flow-logs-for-all-vpcs/
────────────────────────────────────────────────────────────────────────────────


  timings
  ──────────────────────────────────────────
  disk i/o             125.201µs
  parsing              86.268947ms
  adaptation           86.101µs
  checks               8.436632ms
  total                94.916881ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     69
  files read           4

  results
  ──────────────────────────────────────────
  passed               2
  ignored              0
  critical             0
  high                 0
  medium               1
  low                  0

  2 passed, 1 potential problem(s) detected.

@clouddrove-ci
Copy link
Member

Terraform Security Scan Failed

Show Output
Result #1 MEDIUM VPC Flow Logs is not enabled for VPC  
────────────────────────────────────────────────────────────────────────────────
  main.tf:27-51
────────────────────────────────────────────────────────────────────────────────
   27resource "aws_vpc" "default" {
   28count = var.vpc_enabled ? 1 : 0
   2930cidr_block                           = var.cidr_block
   31ipv4_ipam_pool_id                    = try(var.additional_cidr_block.ipv4_ipam_pool_id, null)
   32ipv4_netmask_length                  = try(var.additional_cidr_block.ipv4_netmask_length, null)
   33ipv6_cidr_block                      = try(var.additional_ipv6_cidr_block.ipv6_cidr_block, null)
   34ipv6_ipam_pool_id                    = try(var.additional_ipv6_cidr_block.ipv6_ipam_pool_id, null)
   35ipv6_netmask_length                  = try(var.additional_ipv6_cidr_block.ipv6_netmask_length, null)
   ..  
────────────────────────────────────────────────────────────────────────────────
          ID aws-ec2-require-vpc-flow-logs-for-all-vpcs
      Impact Without VPC flow logs, you risk not having enough information about network traffic flow to investigate incidents or identify security issues.
  Resolution Enable flow logs for VPC

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/aws/ec2/require-vpc-flow-logs-for-all-vpcs/
────────────────────────────────────────────────────────────────────────────────


  timings
  ──────────────────────────────────────────
  disk i/o             116.201µs
  parsing              46.426512ms
  adaptation           139.201µs
  checks               15.385003ms
  total                62.066917ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     69
  files read           4

  results
  ──────────────────────────────────────────
  passed               2
  ignored              0
  critical             0
  high                 0
  medium               1
  low                  0

  2 passed, 1 potential problem(s) detected.

@clouddrove-ci
Copy link
Member

Terraform Security Scan Failed

Show Output
Result #1 MEDIUM VPC Flow Logs is not enabled for VPC  
────────────────────────────────────────────────────────────────────────────────
  main.tf:27-51
────────────────────────────────────────────────────────────────────────────────
   27resource "aws_vpc" "default" {
   28count = var.vpc_enabled ? 1 : 0
   2930cidr_block                           = var.cidr_block
   31ipv4_ipam_pool_id                    = try(var.additional_cidr_block.ipv4_ipam_pool_id, null)
   32ipv4_netmask_length                  = try(var.additional_cidr_block.ipv4_netmask_length, null)
   33ipv6_cidr_block                      = try(var.additional_ipv6_cidr_block.ipv6_cidr_block, null)
   34ipv6_ipam_pool_id                    = try(var.additional_ipv6_cidr_block.ipv6_ipam_pool_id, null)
   35ipv6_netmask_length                  = try(var.additional_ipv6_cidr_block.ipv6_netmask_length, null)
   ..  
────────────────────────────────────────────────────────────────────────────────
          ID aws-ec2-require-vpc-flow-logs-for-all-vpcs
      Impact Without VPC flow logs, you risk not having enough information about network traffic flow to investigate incidents or identify security issues.
  Resolution Enable flow logs for VPC

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/aws/ec2/require-vpc-flow-logs-for-all-vpcs/
────────────────────────────────────────────────────────────────────────────────


  timings
  ──────────────────────────────────────────
  disk i/o             147.101µs
  parsing              117.299691ms
  adaptation           197.902µs
  checks               11.996901ms
  total                129.641595ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     69
  files read           4

  results
  ──────────────────────────────────────────
  passed               2
  ignored              0
  critical             0
  high                 0
  medium               1
  low                  0

  2 passed, 1 potential problem(s) detected.

@clouddrove-ci
Copy link
Member

Terraform Security Scan Failed

Show Output
Result #1 MEDIUM VPC Flow Logs is not enabled for VPC  
────────────────────────────────────────────────────────────────────────────────
  main.tf:27-51
────────────────────────────────────────────────────────────────────────────────
   27resource "aws_vpc" "default" {
   28count = var.vpc_enabled ? 1 : 0
   2930cidr_block                           = var.cidr_block
   31ipv4_ipam_pool_id                    = try(var.additional_cidr_block.ipv4_ipam_pool_id, null)
   32ipv4_netmask_length                  = try(var.additional_cidr_block.ipv4_netmask_length, null)
   33ipv6_cidr_block                      = try(var.additional_ipv6_cidr_block.ipv6_cidr_block, null)
   34ipv6_ipam_pool_id                    = try(var.additional_ipv6_cidr_block.ipv6_ipam_pool_id, null)
   35ipv6_netmask_length                  = try(var.additional_ipv6_cidr_block.ipv6_netmask_length, null)
   ..  
────────────────────────────────────────────────────────────────────────────────
          ID aws-ec2-require-vpc-flow-logs-for-all-vpcs
      Impact Without VPC flow logs, you risk not having enough information about network traffic flow to investigate incidents or identify security issues.
  Resolution Enable flow logs for VPC

  More Information
  - https://aquasecurity.github.io/tfsec/latest/checks/aws/ec2/require-vpc-flow-logs-for-all-vpcs/
────────────────────────────────────────────────────────────────────────────────


  timings
  ──────────────────────────────────────────
  disk i/o             99.1µs
  parsing              72.03765ms
  adaptation           86.3µs
  checks               8.063272ms
  total                80.286322ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    1
  blocks processed     69
  files read           4

  results
  ──────────────────────────────────────────
  passed               2
  ignored              0
  critical             0
  high                 0
  medium               1
  low                  0

  2 passed, 1 potential problem(s) detected.

@anmolnagpal anmolnagpal merged commit 02502c0 into master Jun 30, 2023
@delete-merged-branch delete-merged-branch bot deleted the issue-465 branch June 30, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants