fix: Updated aks module according to latest azurerm version #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+2
to
+432
| client_secret = var.client_secret | ||
| } | ||
| } | ||
| dynamic "storage_profile" { | ||
| for_each = var.storage_profile_enabled ? ["storage_profile"] : [] | ||
|
|
||
| content { | ||
| blob_driver_enabled = var.storage_profile.blob_driver_enabled | ||
| disk_driver_enabled = var.storage_profile.disk_driver_enabled | ||
| # disk_driver_version = var.storage_profile.disk_driver_version | ||
| file_driver_enabled = var.storage_profile.file_driver_enabled | ||
| snapshot_controller_enabled = var.storage_profile.snapshot_controller_enabled | ||
| } | ||
| } | ||
|
|
||
| identity { | ||
| type = var.private_cluster_enabled && var.private_dns_zone_type == "Custom" ? "UserAssigned" : "SystemAssigned" | ||
| } | ||
|
|
||
| dynamic "web_app_routing" { | ||
| for_each = var.web_app_routing == null ? [] : ["web_app_routing"] | ||
|
|
||
| content { | ||
| dns_zone_ids = var.web_app_routing.dns_zone_id | ||
| } | ||
| } | ||
|
|
||
| dynamic "linux_profile" { | ||
| for_each = var.linux_profile != null ? [true] : [] | ||
| iterator = lp | ||
| content { | ||
| admin_username = var.linux_profile.username | ||
|
|
||
| ssh_key { | ||
| key_data = var.linux_profile.ssh_key | ||
| } | ||
| } | ||
| } | ||
|
|
||
| dynamic "workload_autoscaler_profile" { | ||
| for_each = var.workload_autoscaler_profile == null ? [] : [var.workload_autoscaler_profile] | ||
|
|
||
| content { | ||
| keda_enabled = workload_autoscaler_profile.value.keda_enabled | ||
| vertical_pod_autoscaler_enabled = workload_autoscaler_profile.value.vertical_pod_autoscaler_enabled | ||
| } | ||
| } | ||
|
|
||
|
|
||
|
|
||
|
|
||
| dynamic "windows_profile" { | ||
| for_each = var.windows_profile != null ? [var.windows_profile] : [] | ||
|
|
||
| content { | ||
| admin_username = windows_profile.value.admin_username | ||
| admin_password = windows_profile.value.admin_password | ||
| license = windows_profile.value.license | ||
|
|
||
| dynamic "gmsa" { | ||
| for_each = windows_profile.value.gmsa != null ? [windows_profile.value.gmsa] : [] | ||
|
|
||
| content { | ||
| dns_server = gmsa.value.dns_server | ||
| root_domain = gmsa.value.root_domain | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| network_profile { | ||
| network_plugin = var.network_plugin | ||
| network_policy = var.network_policy | ||
| network_data_plane = var.network_data_plane | ||
| dns_service_ip = cidrhost(var.service_cidr, 10) | ||
| service_cidr = var.service_cidr | ||
| load_balancer_sku = var.load_balancer_sku | ||
| network_plugin_mode = var.network_plugin_mode | ||
| outbound_type = var.outbound_type | ||
| pod_cidr = var.net_profile_pod_cidr | ||
|
|
||
|
|
||
| dynamic "load_balancer_profile" { | ||
| for_each = var.load_balancer_profile_enabled && var.load_balancer_sku == "standard" ? [1] : [] | ||
|
|
||
| content { | ||
| idle_timeout_in_minutes = var.load_balancer_profile_idle_timeout_in_minutes | ||
| managed_outbound_ip_count = var.load_balancer_profile_managed_outbound_ip_count | ||
| managed_outbound_ipv6_count = var.load_balancer_profile_managed_outbound_ipv6_count | ||
| outbound_ip_address_ids = var.load_balancer_profile_outbound_ip_address_ids | ||
| outbound_ip_prefix_ids = var.load_balancer_profile_outbound_ip_prefix_ids | ||
| outbound_ports_allocated = var.load_balancer_profile_outbound_ports_allocated | ||
| } | ||
| } | ||
| } | ||
| depends_on = [ | ||
| azurerm_role_assignment.aks_uai_private_dns_zone_contributor, | ||
| ] | ||
| tags = module.labels.tags | ||
| } |
Check warning
Code scanning / defsec
Ensure AKS logging to Azure Monitoring is Configured Warning
|
|
|
13archit
reviewed
Oct 14, 2024
| } | ||
| } | ||
|
|
||
| # dynamic "api_server_access_profile" { |
There was a problem hiding this comment.
Why is this commented? If not required please remove it or uncomment.
13archit
reviewed
Oct 14, 2024
| dynamic "azure_active_directory_role_based_access_control" { | ||
| for_each = var.role_based_access_control == null ? [] : var.role_based_access_control | ||
| content { | ||
| # managed = azure_active_directory_role_based_access_control.value.managed |
13archit
reviewed
Oct 14, 2024
| ## Managed By : CloudDrove | ||
| ## Copyright @ CloudDrove. All Right Reserved. | ||
|
|
||
| ## Vritual Network and Subnet Creation |
There was a problem hiding this comment.
Can we remove this part and above one also
13archit
reviewed
Oct 14, 2024
| eviction_policy = null | ||
| spot_max_price = null | ||
| } | ||
| # default_spot_node_pool = { |
13archit
reviewed
Oct 14, 2024
| os_disk_size_gb = 128 | ||
| } | ||
|
|
||
| # default_spot_instanse = { |
There was a problem hiding this comment.
Why is this commented? If not required please remove it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
subscription_idfor provider in root modulewhy