Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal-247] fix- sonar bug and default variable passed in variable #7

Merged
merged 3 commits into from
Apr 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions _example/example.tf
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ provider "azurerm" {

module "resource_group" {
source = "clouddrove/resource-group/azure"
version = "1.0.0"
version = "1.0.2"

name = "rg-appi-test"
environment = "test"
Expand All @@ -21,17 +21,13 @@ module "application-insights" {
resource_group_name = module.resource_group.resource_group_name
location = module.resource_group.resource_group_location
# workspace_id = module.log-analytics.workspace_id
application_type = "web"
daily_data_cap_in_gb = 30
application_type = "web"

##web test
web_test_enable = true
kind = "ping"
frequency = 300
timeout = 60
monitored_enabled = true
retry_enabled = true
geo_locations = ["us-ca-sjc-azr", "us-tx-sn1-azr", "us-il-ch1-azr", "us-va-ash-azr", "us-fl-mia-edge"]
list_of_test_urls = ["https://www.google.com", ]
web_test_name = ["google", ]
}
2 changes: 1 addition & 1 deletion main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ resource "azurerm_application_insights" "application_insights" {
workspace_id = var.workspace_id
local_authentication_disabled = var.local_authentication_disabled
internet_ingestion_enabled = var.internet_ingestion_enabled
internet_query_enabled = var.internet_query_enable
internet_query_enabled = var.internet_query_enabled
force_customer_storage_for_profiler = var.force_customer_storage_for_profiler
tags = module.labels.tags
}
Expand Down
17 changes: 6 additions & 11 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ variable "sampling_percentage" {

variable "daily_data_cap_in_gb" {
type = number
default = null
default = 30
description = "Specifies the Application Insights component daily data volume cap in GB."
}

Expand All @@ -109,12 +109,7 @@ variable "timeout" {
}
variable "monitored_enabled" {
type = bool
default = false
}
variable "list_of_test_locations" {
type = list(string)
default = ["us-ca-sjc-azr", "us-tx-sn1-azr", "us-il-ch1-azr", "us-va-ash-azr", "us-fl-mia-edge"]
description = "List of Azure locations that will perform the specified web tests. Default is set to 5 US locations. Microsoft recommendation is a minimum of 5 test locations with an alert threshold of N-2. Ref: https://docs.microsoft.com/en-us/azure/azure-monitor/app/monitor-web-app-availability"
default = true
}
variable "retry_enabled" {
type = bool
Expand Down Expand Up @@ -162,12 +157,12 @@ variable "local_authentication_disabled" {
}
variable "internet_ingestion_enabled" {
type = bool
default = true
default = false
description = " (Optional) Should the Application Insights component support ingestion over the Public Internet? Defaults to true."
}
variable "internet_query_enable" {
variable "internet_query_enabled" {
type = bool
default = true
default = false
description = "(Optional) Should the Application Insights component support querying over the Public Internet? Defaults to true."
}
variable "force_customer_storage_for_profiler" {
Expand All @@ -181,7 +176,7 @@ variable "web_test_name" {
}
variable "geo_locations" {
type = list(string)
default = []
default = ["us-ca-sjc-azr", "us-tx-sn1-azr", "us-il-ch1-azr", "us-va-ash-azr", "us-fl-mia-edge"]
description = "Specifies a list of where to physically run the tests from to give global coverage for accessibility of your application."
}

Expand Down