Skip to content

Commit

Permalink
fix: update variables types
Browse files Browse the repository at this point in the history
  • Loading branch information
mamrajyadav committed Jan 12, 2024
1 parent 4d40f47 commit cc7ea08
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 13 deletions.
2 changes: 1 addition & 1 deletion _example/basic/example.tf
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ module "dns_zone" {
source = "../.."
name = "app"
environment = "test"
resource_group_name = "NetworkWatcherRG"
resource_group_name = "test-rg"
dns_zone_names = "example.com"
private_registration_enabled = false
private_dns = false
Expand Down
2 changes: 1 addition & 1 deletion _example/basic/versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ terraform {
required_providers {
azurerm = {
source = "hashicorp/azurerm"
version = ">=3.85.0"
version = ">=3.86.0"
}
}
}
2 changes: 1 addition & 1 deletion _example/complete/versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ terraform {
required_providers {
azurerm = {
source = "hashicorp/azurerm"
version = ">=3.85.0"
version = ">=3.86.0"
}
}
}
1 change: 0 additions & 1 deletion main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ resource "azurerm_dns_cname_record" "records_cname" {
record = lookup(each.value, "record", null) # Optional(Conflicts with target_resource_id) {Either record OR target_resource_id must be specified, but not both.}
target_resource_id = lookup(each.value, "target_resource_id", null) # Optional(Conflicts with record) {Either records OR target_resource_id must be specified, but not both.}
tags = module.labels.tags

}

##-----------------------------------------------------------------------------
Expand Down
24 changes: 16 additions & 8 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ variable "environment" {
}

variable "label_order" {
type = list(any)
type = list(string)
default = ["name", "environment"]
description = "Label order, e.g. sequence of application name and environment `name`,`environment`,'attribute' [`webserver`,`qa`,`devops`,`public`,] ."
}
Expand All @@ -31,15 +31,15 @@ variable "repository" {
}

variable "dns_zone_names" {
default = null
type = string
default = null
description = "The public dns zone to be created for internal vnet resolution"

}

variable "private_dns_zone_name" {
default = null
type = string
default = null
description = "The private dns zone to be created for internal vnet resolution"
}

Expand All @@ -50,8 +50,8 @@ variable "resource_group_name" {
}

variable "private_registration_enabled" {
default = true
type = bool
default = true
description = "Is auto-registration of virtual machine records in the virtual network in the Private DNS zone enabled?"
}
variable "enabled" {
Expand All @@ -75,19 +75,27 @@ variable "virtual_network_id" {
}

variable "soa_record_private_dns" {
type = list(any)
type = list(object({}))
default = []
description = "Customize details about the root block device of the instance. See Block Devices below for details."
}

variable "a_records" {
type = any
type = list(object({
name = string
ttl = number
records = list(string)
}))
default = []
description = "List of a records to be added in azure dns zone."
}

variable "cname_records" {
type = any
type = list(object({
name = string
ttl = number
record = string
}))
default = []
description = "List of cname records"
}
Expand All @@ -103,7 +111,7 @@ variable "ns_records" {
}

variable "soa_record" {
type = list(any)
type = list(object({}))
default = []
description = "Customize details about the root block device of the instance. See Block Devices below for details."
}
2 changes: 1 addition & 1 deletion versions.tf
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ terraform {
required_providers {
azurerm = {
source = "hashicorp/azurerm"
version = ">=3.85.0"
version = ">=3.86.0"
}
random = {
source = "hashicorp/random"
Expand Down

0 comments on commit cc7ea08

Please sign in to comment.