Skip to content

Commit

Permalink
fix: Update https_traffic_only_enabled to enable_https_traffic_only (#74
Browse files Browse the repository at this point in the history
)

* fix: Updated provder configuration in examples/complete and Added log-analytics arguments

* fix: Updated CODEOWNDERS

* fix: Fixed variable name

---------

Co-authored-by: Archit Chopra <chopra13archit@gmail.com>
  • Loading branch information
ravimalvia10 and 13archit authored Oct 15, 2024
1 parent f058afa commit b30a448
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 10 deletions.
8 changes: 2 additions & 6 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,6 +1,2 @@
.github/* @clouddrove/approvers

* @clouddrove/clouddrovians @clouddrove/approvers

.github/mergify.yml @clouddrove/admins
.github/CODEOWNERS @clouddrove/admins
# These owners will be the default owners for everything in the repo.
* @anmolnagpal @clouddrove-ci @clouddrove/terraform-azure-admins
12 changes: 10 additions & 2 deletions examples/complete/example.tf
Original file line number Diff line number Diff line change
Expand Up @@ -76,23 +76,31 @@ module "log-analytics" {
name = local.name
environment = local.environment
label_order = local.label_order
create_log_analytics_workspace = false
create_log_analytics_workspace = true # Set it 'false' if you don't want resource log-analytics workspace to be created
log_analytics_workspace_sku = "PerGB2018"
daily_quota_gb = "-1"
internet_ingestion_enabled = true
internet_query_enabled = true
resource_group_name = module.resource_group.resource_group_name
log_analytics_workspace_location = module.resource_group.resource_group_location
storage_account_id = module.storage.storage_account_id
diagnostic_setting_enable = false # Set it 'true' if you want azurerm_monitor_diagnostic_setting to be enabled

}

##-----------------------------------------------------------------------------
## Key Vault module call.
##-----------------------------------------------------------------------------
module "vault" {
providers = {
azurerm.main_sub = azurerm
azurerm.dns_sub = azurerm.peer
}

source = "clouddrove/key-vault/azure"
version = "1.1.0"

name = "vae5960581"
name = "vae59605811"
environment = "test"
label_order = ["name", "environment", ]
resource_group_name = module.resource_group.resource_group_name
Expand Down
2 changes: 1 addition & 1 deletion main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ resource "azurerm_storage_account" "storage" {
account_tier = var.account_tier
access_tier = var.access_tier
account_replication_type = var.account_replication_type
https_traffic_only_enabled = var.https_traffic_only_enabled
https_traffic_only_enabled = var.enable_https_traffic_only
min_tls_version = var.min_tls_version
is_hns_enabled = var.is_hns_enabled
sftp_enabled = var.sftp_enabled
Expand Down
2 changes: 1 addition & 1 deletion variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ variable "account_replication_type" {
description = "Defines the type of replication to use for this storage account. Valid options are LRS, GRS, RAGRS, ZRS, GZRS and RAGZRS. Changing this forces a new resource to be created when types LRS, GRS and RAGRS are changed to ZRS, GZRS or RAGZRS and vice versa."
}

variable "https_traffic_only_enabled" {
variable "enable_https_traffic_only" {
type = bool
default = true
description = " Boolean flag which forces HTTPS if enabled, see here for more information."
Expand Down

0 comments on commit b30a448

Please sign in to comment.