Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update code and add tf latest version #18

Merged
merged 7 commits into from
Jan 2, 2024
Merged

fix: update code and add tf latest version #18

merged 7 commits into from
Jan 2, 2024

Conversation

mamrajyadav
Copy link
Contributor

what

  • add terraform and azure provider latest version.
  • fix tflint and tfsec issue.

@mamrajyadav mamrajyadav requested a review from d4kverma December 12, 2023 08:00
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
resource_group_name = module.resource_group.resource_group_name
location = module.resource_group.resource_group_location
address_space = "10.0.0.0/16"
existing_ddos_pp = "/subscriptions/068245d4-3c94-42fe-9c4d-9e5e1cabc60c/resourceGroups/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you pls remove subscription id from here.

variables.tf Show resolved Hide resolved
@13archit 13archit self-requested a review January 2, 2024 08:27
Copy link
Member

@13archit 13archit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix Tfchecks.

Copy link
Member

@d4kverma d4kverma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d4kverma d4kverma merged commit fdadd26 into master Jan 2, 2024
15 checks passed
@delete-merged-branch delete-merged-branch bot deleted the azure_1 branch January 2, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants