Error handling for wrapper - client - server call mismatches #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wmudge @cmperro I implemented this to handle the possibility of version mismatches between CDPCLI and CDP Control Plane, both now with the new DF API, but also in consideration of Private Cloud versions in future. |
Chaffelson
force-pushed
the
handle_client_mismatch
branch
from
b04241b to
65c3d49
Compare
|
@Chaffelson -- has conflicts that need resolution. |
wmudge
requested changes
Sep 16, 2021
…s not available in the installed CDPCLI Add error handling for when CDPCLI makes a call that is not available in the remote CDP Control Plane Signed-off-by: Daniel Chaffelson <chaffelson@gmail.com>
…out of call() Directly Handle parsing AttributeError and ValidationError into common format Move Handling REMOTE_NOT_IMPLMENTED in CdpError Signed-off-by: Daniel Chaffelson <chaffelson@gmail.com>
Chaffelson
force-pushed
the
handle_client_mismatch
branch
from
65c3d49 to
1d9b387
Compare
wmudge
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add error handling for when the user requests a call from cdpy that is not available in the installed CDPCLI
Add error handling for when CDPCLI makes a call that is not available in the remote CDP Control Plane
Signed-off-by: Daniel Chaffelson chaffelson@gmail.com