Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cluster service and related resource modules #220

Merged
merged 36 commits into from
May 8, 2024
Merged

Add cluster service and related resource modules #220

merged 36 commits into from
May 8, 2024

Conversation

wmudge
Copy link
Member

@wmudge wmudge commented Apr 12, 2024

  • Service and service config
  • Service role and config
  • Service role config group and config
  • Service type

@wmudge wmudge added the enhancement New feature or request label Apr 12, 2024
@wmudge wmudge added this to the Release 4.3.1 milestone Apr 12, 2024
@wmudge wmudge requested a review from a team April 12, 2024 19:15
rsuplina
rsuplina requested changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@rsuplina rsuplina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments on all places that I think need some updates.

plugins/modules/service_role.py Outdated Show resolved Hide resolved
tests/unit/plugins/modules/service_role_info/test_service_role_info.py Show resolved Hide resolved
tests/unit/plugins/modules/service_role_info/test_service_role_info.py Show resolved Hide resolved
tests/unit/plugins/modules/service_role_config_info/test_service_role_config_info.py Show resolved Hide resolved
...s/unit/plugins/modules/service_role_config_group_info/test_service_role_config_group_info.py Outdated Show resolved Hide resolved
...it/plugins/modules/service_role_config_group_config/test_service_role_config_group_config.py Outdated Show resolved Hide resolved
tests/unit/plugins/modules/service_role_config/test_service_role_config.py Show resolved Hide resolved
tests/unit/plugins/modules/service_role_config/test_service_role_config.py Show resolved Hide resolved
tests/unit/plugins/modules/cm_config/test_cm_config.py Show resolved Hide resolved
wmudge added 22 commits May 6, 2024 14:43
@wmudge
Add cluster_service_info module
d5b8760 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Add cluster_service_config_info module
4996655 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Add test for cluster_service_config_info
6f23720 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Strip trailing forward slash and whitespace from the endpoint parameter
97713b2 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Add cluster_service_types_info module
aabe5cb 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Add tests for cluster_service_info module
874ebfd 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
* Add HTTP proxy parameter and user agent header
94dfbe1 
* Update argument_spec signatures

Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
* Update cluster_service_type_info module with try/except on invalid …
6036d2e 
…cluster

* Add tests for cluster_service_type_info module

Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Add mutation parameters
477c987 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Add cluster_service module
be0849a 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Add cluster_service_config module
577018f 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Move service output filtering to cm_utils and fix parameter names
4a6a851 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
* Add service output filtering
ec8693f 
* Update API error handling messages
* Add wait_command for CM command polling

Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Add cluster_service_role_info module and test
18f9888 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Add purge doc_fragment
d0596d6 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
* Update output filtering to handle role and service
a0b39f7 
* Add function handle parameter change sets

Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Add service_role module and tests
521a033 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Add service_role_config module and tests
e05d13a 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Add service_role_config_info module and tests
01bee5b 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Add cloudera.css to docsbuild and add doc format
a368643 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Update service, role, and role config group parsers to simplify refer…
c661ec8 
…ence objects

Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Add service_role_config_group_info module and tests
09937a8 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
wmudge added 12 commits May 6, 2024 14:43
@wmudge
Add service_role_config_group_config module and tests
eb3d19f 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Add service_role_config_group_config_info module and tests
d851222 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Add service_role_config_group module and tests
c3cda01 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Update call_api datatype test
19613d7 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Update to use CM_ENDPOINT
3948d24 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Inline commands for stopping a role
983d531 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Add missing 'role' parameter in basic test
3ad6f59 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Remove invalid test
a3ff5e1 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Update to use correct module under test (updated tests TBD)
39d0b4c 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Add missing parameter in regex and missing role parameter
a8ae052 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Comment out check mode in tests
b556859 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Formatting
cfa4704 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge wmudge force-pushed the feature/cluster_service-modules branch from 909e5a1 to cfa4704 Compare May 6, 2024 18:43
wmudge added 2 commits May 8, 2024 11:11
@wmudge
Add parameters into basic spec checks
2fb70dd 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Update tests to include role parameter
6fb7766 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge wmudge merged commit 86b541c into cloudera-labs:devel May 8, 2024
4 checks passed
@wmudge wmudge deleted the feature/cluster_service-modules branch May 8, 2024 15:56
@wmudge wmudge modified the milestones: Release 4.3.1, Release 4.4.0 May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsuplina rsuplina rsuplina approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request validated
Milestone
Release 4.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wmudge @rsuplina