Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide Indexer to index files #27

Merged
merged 12 commits into from
Nov 21, 2024
Merged

Provide Indexer to index files #27

merged 12 commits into from
Nov 21, 2024

Conversation

conradocloudera
Copy link
Collaborator

@conradocloudera conradocloudera commented Nov 20, 2024 •
edited
Loading

Make the indexing explicit (vs using llama index) for more control, and make dependencies concrete.

The test skipped will be marked for restore once the dependency injection is properly handled.

@conradocloudera conradocloudera marked this pull request as ready for review November 20, 2024 22:59
jkwatson
jkwatson approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@conradocloudera conradocloudera merged commit 8ddbedd into main Nov 21, 2024
1 check passed
@conradocloudera conradocloudera deleted the cm/indexer branch November 21, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkwatson jkwatson jkwatson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conradocloudera @jkwatson