Removing gunicorn 19.9.0 version #3312
Conversation
ranade1
requested review from
wing2fly,
amitsrivastava,
athithyaaselvam,
agl29 and
Harshg999
| - Removed fallback for `types.SimpleNamespace` in tests utils | ||
| - Use `SourceFileLoader` instead instead of `execfile_` | ||
| - Use `importlib` instead of `__import__` and eval` | ||
| - Fixed eventlet patching |
There was a problem hiding this comment.
Might need to upgrade eventlet also
| @@ -130,7 +130,7 @@ def is_already_handled(self, respiter): | |||
| return super().is_already_handled(respiter) | |||
|
|
|||
| def init_process(self): | |||
| self.patch() | |||
| #self.patch() | |||
There was a problem hiding this comment.
this calls
--> line 124 above eventlet.monkey_patch(), then calls
--> https://github.com/cloudera/hue/blob/master/desktop/core/ext-py3/eventlet-0.30.2/eventlet/__init__.py#L55, then calls
--> https://github.com/cloudera/hue/blob/master/desktop/core/ext-py3/eventlet-0.30.2/eventlet/patcher.py#L225-L364
There are lines of code handle multiple database modules and threading, so I don't feel safe to remove monkey patch in gunicorn.
There was a problem hiding this comment.
To upgrade eventlet and work with Gunicorn, a fix need to patch gunicorn. Not sure if this is the one you have tried
Issue: benoitc/gunicorn#2581
Fix: benoitc/gunicorn@1299ea9
There was a problem hiding this comment.
The fix eventlet/eventlet@7aa50ad5 in eventlet was the reason why I pulled in the whole of eventlet library. If the new gunicorn is pulling in eventlet v0.32.0+, then we can do away with our copy of eventlet.
|
This PR is stale because it has been open 45 days with no activity and is not labeled "Prevent stale". Remove "stale" label or comment or this will be closed in 10 days. |
What changes were proposed in this pull request?
How was this patch tested?
Please review Hue Contributing Guide before opening a pull request.