Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] convert remaining nose based test to pytest #3705

Merged
merged 1 commit into from
Apr 18, 2024
Merged

[test] convert remaining nose based test to pytest #3705

merged 1 commit into from
Apr 18, 2024

Conversation

agl29
Copy link
Collaborator

@agl29 agl29 commented Apr 18, 2024 •
edited
Loading

What changes were proposed in this pull request?

  • Converted previously unconverted tests to pytest format

How was this patch tested?

  • Locally
  • unittest

@agl29 agl29 force-pushed the nose_code_remove branch from 209e257 to 3cdd124 Compare April 18, 2024 06:34
@agl29 agl29 force-pushed the nose_code_remove branch from 3cdd124 to 9a5694b Compare April 18, 2024 07:17
Harshg999
Harshg999 approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@Harshg999 Harshg999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

JohanAhlen
JohanAhlen approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@JohanAhlen JohanAhlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@agl29 agl29 merged commit 432cd98 into master Apr 18, 2024
4 checks passed
@agl29 agl29 deleted the nose_code_remove branch April 18, 2024 08:54
athithyaaselvam pushed a commit that referenced this pull request Jun 10, 2024
@agl29 @wing2fly
CDPD-68828: [test] convert remaining nose based test to pytest (#3705)
08a50b4 
(cherry picked from commit 432cd98)
(cherry picked from commit acee15c61482c6d3b1a259dcc45e9959309146ca)
Change-Id: Id49fe42da97a5e4f27d1fbf5505558dd54695ada
(cherry picked from commit a21757188d632ae822c6fa688e40e06a57f03f2b)
agl29 added a commit that referenced this pull request Aug 21, 2024
@agl29
CDPD-67584: CDPD-68828 [test] convert remaining nose based test to py…
ad1816b 
…test (#3705)

(cherry picked from commit 432cd98)
(cherry picked from commit acee15c61482c6d3b1a259dcc45e9959309146ca)
Change-Id: Id49fe42da97a5e4f27d1fbf5505558dd54695ada
(cherry picked from commit a21757188d632ae822c6fa688e40e06a57f03f2b)
(cherry picked from commit 08a50b4)
(cherry picked from commit cde64b9821d1d1ee8bc625c070370539e94834b0)
agl29 added a commit that referenced this pull request Sep 5, 2024
@agl29
CDPD-67584: CDPD-68828 [test] convert remaining nose based test to py…
615b89c 
…test (#3705)

(cherry picked from commit 432cd98)
(cherry picked from commit acee15c61482c6d3b1a259dcc45e9959309146ca)
Change-Id: Id49fe42da97a5e4f27d1fbf5505558dd54695ada
(cherry picked from commit a21757188d632ae822c6fa688e40e06a57f03f2b)
(cherry picked from commit 08a50b4)
Alterrien pushed a commit to Alterrien/hue that referenced this pull request Dec 19, 2024
@agl29
[test] convert remaining nose based test to pytest (cloudera#3705)
9928b8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harshg999 Harshg999 Harshg999 approved these changes

@JohanAhlen JohanAhlen JohanAhlen approved these changes

@wing2fly wing2fly Awaiting requested review from wing2fly

@athithyaaselvam athithyaaselvam Awaiting requested review from athithyaaselvam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agl29 @JohanAhlen @Harshg999