Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middleware to switch the upload handler and use HDFSfileUploadHandler for document upload #3830

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

athithyaaselvam
Copy link
Collaborator

What changes were proposed in this pull request?

Middleware to switch the upload handler and use HDFSfileUploadHandler for document upload. When the chunked_file_uploader and task_server config is enabled, the document uploads tries to use FineUploaderChunkedUploadHandler. Since user's don't upload large files in document upload's page (small json files with saved queries are uploaded), the chunked_file_upload implementation isn't needed. So adding a middleware to switch the upload handler in Documents upload page to HDFSfileUploadHandler even when the HDFS, S3, Azure FS might use the FineUploaderChunkedUploadHandler.

How was this patch tested?

Tested on mac, docker based system. Tested uploading a document concurrently during HDFS, S3, Azure file uploads.

Please review Hue Contributing Guide before opening a pull request.

… for document upload

Change-Id: Iab7b73cfcefd42348a37a38d9bafb9964bf551d4
@Harshg999
Copy link
Collaborator

Why are we adding a dedicated middleware only for this specific use-case? Can't we do this closer to the core document import code section?

Copy link

This PR is stale because it has been open 45 days with no activity and is not labeled "Prevent stale". Remove "stale" label or comment or this will be closed in 10 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants