Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui-storagebrowser] adds disable button to InputModal component #3924

Merged
merged 4 commits into from
Jan 7, 2025
Merged

[ui-storagebrowser] adds disable button to InputModal component #3924

merged 4 commits into from
Jan 7, 2025

Conversation

ramprasadagarwal
Copy link
Collaborator

What changes were proposed in this pull request?

  • When API calls are in progress, the buttons of modal need to be disabled to indicate the progress.

How was this patch tested?

  • Updated the test cases

@ramprasadagarwal ramprasadagarwal self-assigned this Dec 19, 2024
@ramprasadagarwal ramprasadagarwal enabled auto-merge (squash) December 20, 2024 21:55
nidhibhatg
nidhibhatg approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@nidhibhatg nidhibhatg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

JohanAhlen
JohanAhlen approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@JohanAhlen JohanAhlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ramprasadagarwal ramprasadagarwal merged commit f3b3ec9 into master Jan 7, 2025
5 of 6 checks passed
@ramprasadagarwal ramprasadagarwal deleted the feat/input-modal branch January 7, 2025 10:30
tabraiz12 pushed a commit that referenced this pull request Jan 27, 2025
@ramprasadagarwal
CDPD-77556: [ui-storagebrowser] adds disable button to InputModal com…
22ac2d6 
…ponent (#3924)

(cherry picked from commit f3b3ec9)
(cherry picked from commit 4139710b9222ecbee86ee50410e0510d7de520b2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanAhlen JohanAhlen JohanAhlen approved these changes

@nidhibhatg nidhibhatg nidhibhatg approved these changes

@tabraiz12 tabraiz12 Awaiting requested review from tabraiz12

@bjornalm bjornalm Awaiting requested review from bjornalm

Assignees

@ramprasadagarwal ramprasadagarwal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramprasadagarwal @JohanAhlen @nidhibhatg