Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui-storagebrowser] refactor / move actions to separate files for scaling #3925

Merged
merged 4 commits into from
Jan 7, 2025
Merged

[ui-storagebrowser] refactor / move actions to separate files for scaling #3925

merged 4 commits into from
Jan 7, 2025

Conversation

ramprasadagarwal
Copy link
Collaborator

What changes were proposed in this pull request?

  • As no of actions are significant, keeping everything in file would be difficult to scale and maintain. This PR moves the actions to separate files so that they isolate the working of the action into its file.

How was this patch tested?

  • Added unit test cases

@ramprasadagarwal ramprasadagarwal self-assigned this Dec 19, 2024
nidhibhatg
nidhibhatg reviewed Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@nidhibhatg nidhibhatg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

...apps/storageBrowser/StorageDirectoryPage/StorageBrowserActions/StorageBrowserActions.util.ts Outdated
} from '../../../../utils/storageBrowserUtils';

export enum ActionType {
Copy = 'copy',
Move = 'move',
Summary = 'summary',
Rename = 'rename',
Repilcation = 'repilcation'
Repilcation = 'repilcation',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: replication*

JohanAhlen
JohanAhlen approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@JohanAhlen JohanAhlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from feat/input-modal to master January 7, 2025 10:30
@ramprasadagarwal ramprasadagarwal enabled auto-merge (squash) January 7, 2025 10:31
@ramprasadagarwal ramprasadagarwal merged commit 7e9165b into master Jan 7, 2025
5 of 6 checks passed
@ramprasadagarwal ramprasadagarwal deleted the improv/browser-actions-refactor branch January 7, 2025 10:44
tabraiz12 pushed a commit that referenced this pull request Jan 27, 2025
@ramprasadagarwal
CDPD-77556: [ui-storagebrowser] refactor / move actions to separate f…
9e52d37 
…iles for scaling (#3925)

* [ui-storagebrowser] refactor storage browser actions to separate file for scaling

* fixes the typo

(cherry picked from commit 7e9165b)
(cherry picked from commit 36a20bb6c7f8ad14734d813ea55b90cc51a40e88)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohanAhlen JohanAhlen JohanAhlen approved these changes

@nidhibhatg nidhibhatg nidhibhatg approved these changes

@tabraiz12 tabraiz12 Awaiting requested review from tabraiz12

@bjornalm bjornalm Awaiting requested review from bjornalm

Assignees

@ramprasadagarwal ramprasadagarwal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramprasadagarwal @JohanAhlen @nidhibhatg