[ui-serverLogs] Convert the Server Logs page within Administrator server in ReactJS #3927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananya-agarwal
requested review from
tabraiz12,
JohanAhlen,
bjornalm,
ramprasadagarwal,
Harshg999 and
nidhibhatg
desktop/core/src/desktop/js/apps/admin/ServerLogs/ServerLogsTab.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/admin/ServerLogs/ServerLogsTab.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/admin/ServerLogs/ServerLogsTab.tsx
Outdated
Show resolved
Hide resolved
desktop/core/src/desktop/js/apps/admin/ServerLogs/ServerLogsTab.tsx
Outdated
Show resolved
Hide resolved
| if (!response.ok) { | ||
| throw new Error(`HTTP error! Status: ${response.status}`); | ||
| } | ||
| const json = await response.json(); |
There was a problem hiding this comment.
Can we have an interface for the API response?
ananya-agarwal
force-pushed
the
ServerLogs
branch
2 times, most recently
from
5176707 to
86d277d
Compare
ananya-agarwal
force-pushed
the
ServerLogs
branch
2 times, most recently
from
1e558cf to
386b1c7
Compare
WIP WIP Searchbox working WIP WIP WIP w f WIP r t WIP WIP WIP WIP
ananya-agarwal
force-pushed
the
ServerLogs
branch
from
386b1c7 to
acab827
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update the Server logs page to use React and align it with the Cloudera Design Language.
For Seeing the logs on Server Logs tab, make sure to enable Gunicorn server in local system: Document
How was this patch tested?
Will add unit tests, manual testing
Please review Hue Contributing Guide before opening a pull request.