Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui-storagebrowser] implements error handling #3932

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[ui-storagebrowser] implements error handling #3932

wants to merge 4 commits into from

Conversation

ramprasadagarwal
Copy link
Collaborator

What changes were proposed in this pull request?

  • Adding a new component which takes care of loading and errors.
  1. When loading prop is true it returns a spinner
  2. When any error flag is enabled, it shows the error message
  3. Else renders the children.

How was this patch tested?

  • Added unit test for new component

@ramprasadagarwal ramprasadagarwal self-assigned this Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ramprasadagarwal ramprasadagarwal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ramprasadagarwal