Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDPCP-11599 Added missing fields to datahub resources #100

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

daszabo
Copy link
Contributor

@daszabo daszabo commented Mar 25, 2024

No description provided.

@daszabo daszabo requested a review from a team as a code owner March 25, 2024 13:08
Copy link

github-actions bot commented Mar 25, 2024

Go test coverage: 32.3% for commit 48965c7
⚠️ 2 of 10 packages have zero coverage.
  • github.com/cloudera/terraform-provider-cdp/resources/iam
  • github.com/cloudera/terraform-provider-cdp/resources/ml
View coverage for all packages
# Package Name                                                      | Coverage
+ github.com/cloudera/terraform-provider-cdp/cdpacctest             |    28.0%
+ github.com/cloudera/terraform-provider-cdp/provider               |    78.7%
+ github.com/cloudera/terraform-provider-cdp/resources/datahub      |    37.8%
+ github.com/cloudera/terraform-provider-cdp/resources/datalake     |     2.8%
+ github.com/cloudera/terraform-provider-cdp/resources/environments |    47.5%
- github.com/cloudera/terraform-provider-cdp/resources/iam          |     0.0%
- github.com/cloudera/terraform-provider-cdp/resources/ml           |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/opdb         |     2.6%
+ github.com/cloudera/terraform-provider-cdp/utils                  |    43.8%
+ github.com/cloudera/terraform-provider-cdp/utils/test             |    80.0%

Copy link
Contributor

@gregito gregito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would appreciate some tests 😅 both for the converter change and for the schema change

@daszabo daszabo enabled auto-merge (squash) March 28, 2024 12:47
@daszabo daszabo dismissed gregito’s stale review March 28, 2024 14:49

Added unit tests

@keyki keyki disabled auto-merge March 28, 2024 15:01
@keyki keyki self-requested a review March 28, 2024 15:01
@keyki keyki merged commit 1292c53 into main Mar 28, 2024
6 checks passed
@daszabo daszabo deleted the CDPCP-11599 branch March 28, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants