Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDPCP-12151 Removed incorrect Datahub cluster_template_name validation #134

Merged
merged 1 commit into from
Jun 6, 2024
Merged

CDPCP-12151 Removed incorrect Datahub cluster_template_name validation #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions resources/datahub/schema_aws_datahub.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,8 @@ package datahub
import (
"context"

"github.com/hashicorp/terraform-plugin-framework-validators/stringvalidator"
"github.com/hashicorp/terraform-plugin-framework/path"
"github.com/hashicorp/terraform-plugin-framework/resource"
"github.com/hashicorp/terraform-plugin-framework/resource/schema"
"github.com/hashicorp/terraform-plugin-framework/schema/validator"
"github.com/hashicorp/terraform-plugin-framework/types"

"github.com/cloudera/terraform-provider-cdp/utils"
Expand All @@ -31,9 +28,6 @@ func (r *awsDatahubResource) Schema(_ context.Context, _ resource.SchemaRequest,
"cluster_template": schema.StringAttribute{
MarkdownDescription: "The name of the cluster template.",
Optional: true,
Validators: []validator.String{
stringvalidator.AlsoRequires(path.MatchRelative().AtParent().AtName("instance_group")),
},
},
"cluster_definition": schema.StringAttribute{
MarkdownDescription: "The name of the cluster definition.",
Expand Down
6 changes: 0 additions & 6 deletions resources/datahub/schema_azure_datahub.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,10 @@ package datahub
import (
"context"

"github.com/hashicorp/terraform-plugin-framework-validators/stringvalidator"
"github.com/hashicorp/terraform-plugin-framework/path"
"github.com/hashicorp/terraform-plugin-framework/resource"
"github.com/hashicorp/terraform-plugin-framework/resource/schema"
"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
"github.com/hashicorp/terraform-plugin-framework/resource/schema/stringplanmodifier"
"github.com/hashicorp/terraform-plugin-framework/schema/validator"

"github.com/cloudera/terraform-provider-cdp/utils"
)
Expand All @@ -32,9 +29,6 @@ func (r *azureDatahubResource) Schema(_ context.Context, _ resource.SchemaReques
"cluster_template": schema.StringAttribute{
MarkdownDescription: "The name of the cluster template.",
Optional: true,
Validators: []validator.String{
stringvalidator.AlsoRequires(path.MatchRelative().AtParent().AtName("instance_group")),
},
},
"cluster_definition": schema.StringAttribute{
MarkdownDescription: "The name of the cluster definition.",
Expand Down
6 changes: 0 additions & 6 deletions resources/datahub/schema_gcp_datahub.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,8 @@ package datahub
import (
"context"

"github.com/hashicorp/terraform-plugin-framework-validators/stringvalidator"
"github.com/hashicorp/terraform-plugin-framework/path"
"github.com/hashicorp/terraform-plugin-framework/resource"
"github.com/hashicorp/terraform-plugin-framework/resource/schema"
"github.com/hashicorp/terraform-plugin-framework/schema/validator"
"github.com/hashicorp/terraform-plugin-framework/types"

"github.com/cloudera/terraform-provider-cdp/utils"
Expand Down Expand Up @@ -90,9 +87,6 @@ func (r *gcpDatahubResource) Schema(_ context.Context, _ resource.SchemaRequest,
"cluster_template_name": schema.StringAttribute{
MarkdownDescription: "The name of the cluster template.",
Optional: true,
Validators: []validator.String{
stringvalidator.AlsoRequires(path.MatchRelative().AtParent().AtName("instance_group")),
},
},
"cluster_definition_name": schema.StringAttribute{
MarkdownDescription: "The name of the cluster definition.",
Expand Down
Loading