Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDPCP-12516 - clean up unused functions prior implementing dead code check #144

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

gregito
Copy link
Contributor

@gregito gregito commented Jul 24, 2024

Depends on #143

@gregito gregito requested a review from a team as a code owner July 24, 2024 11:08
@gregito gregito marked this pull request as draft July 24, 2024 11:08
@gregito gregito marked this pull request as ready for review July 24, 2024 11:16
Copy link

github-actions bot commented Jul 24, 2024

Go test coverage: 31.9% for commit 43feecd
⚠️ 2 of 13 packages have zero coverage.
  • github.com/cloudera/terraform-provider-cdp/resources/de
  • github.com/cloudera/terraform-provider-cdp/resources/ml
View coverage for all packages
# Package Name                                                        | Coverage
+ github.com/cloudera/terraform-provider-cdp/cdpacctest               |    26.9%
+ github.com/cloudera/terraform-provider-cdp/provider                 |    78.7%
+ github.com/cloudera/terraform-provider-cdp/resources/datahub        |    36.5%
+ github.com/cloudera/terraform-provider-cdp/resources/datalake       |     7.7%
- github.com/cloudera/terraform-provider-cdp/resources/de             |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/dw             |    83.3%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/cluster/aws |    78.6%
+ github.com/cloudera/terraform-provider-cdp/resources/environments   |    45.8%
+ github.com/cloudera/terraform-provider-cdp/resources/iam            |     1.9%
- github.com/cloudera/terraform-provider-cdp/resources/ml             |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/opdb           |    25.3%
+ github.com/cloudera/terraform-provider-cdp/utils                    |    51.3%
+ github.com/cloudera/terraform-provider-cdp/utils/test               |    68.8%

daszabo
daszabo previously approved these changes Jul 24, 2024
@gregito gregito merged commit 440f237 into main Jul 24, 2024
7 checks passed
@gregito gregito deleted the CDPCP-12516 branch July 24, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants