Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDPCP-12793 Added polling capability to user sycn resource #162

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

daszabo
Copy link
Contributor

@daszabo daszabo commented Sep 25, 2024

No description provided.

@daszabo daszabo requested a review from a team as a code owner September 25, 2024 07:13
Copy link

Go test coverage: 32.3% for commit 3ec0533
⚠️ 2 of 13 packages have zero coverage.
  • github.com/cloudera/terraform-provider-cdp/resources/de
  • github.com/cloudera/terraform-provider-cdp/resources/ml
View coverage for all packages
# Package Name                                                        | Coverage
+ github.com/cloudera/terraform-provider-cdp/cdpacctest               |    26.9%
+ github.com/cloudera/terraform-provider-cdp/provider                 |    78.7%
+ github.com/cloudera/terraform-provider-cdp/resources/datahub        |    36.3%
+ github.com/cloudera/terraform-provider-cdp/resources/datalake       |     8.4%
- github.com/cloudera/terraform-provider-cdp/resources/de             |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/dw             |    83.3%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/cluster/aws |    72.4%
+ github.com/cloudera/terraform-provider-cdp/resources/environments   |    44.3%
+ github.com/cloudera/terraform-provider-cdp/resources/iam            |     2.8%
- github.com/cloudera/terraform-provider-cdp/resources/ml             |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/opdb           |    25.3%
+ github.com/cloudera/terraform-provider-cdp/utils                    |    51.3%
+ github.com/cloudera/terraform-provider-cdp/utils/test               |    68.8%

@gregito
Copy link
Contributor

gregito commented Sep 30, 2024

code part LGTM, though I'm not familiar with the statuses that's been observed during polling, so I suspect it was tested beforehand 🙂

@gregito gregito merged commit a74a80f into main Sep 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants