Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DWX-18781 Data warehouse catalog object management #164

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

tevesz
Copy link
Contributor

@tevesz tevesz commented Oct 23, 2024

Adding creation and deletion options for the data warehouse catalog object type.

@tevesz tevesz requested a review from a team as a code owner October 23, 2024 20:40
Copy link

github-actions bot commented Oct 23, 2024

Go test coverage: 33.0% for commit 63489fb
⚠️ 2 of 14 packages have zero coverage.
  • github.com/cloudera/terraform-provider-cdp/resources/de
  • github.com/cloudera/terraform-provider-cdp/resources/ml
View coverage for all packages
# Package Name                                                            | Coverage
+ github.com/cloudera/terraform-provider-cdp/cdpacctest                   |    26.9%
+ github.com/cloudera/terraform-provider-cdp/provider                     |    78.7%
+ github.com/cloudera/terraform-provider-cdp/resources/datahub            |    36.3%
+ github.com/cloudera/terraform-provider-cdp/resources/datalake           |     8.4%
- github.com/cloudera/terraform-provider-cdp/resources/de                 |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/dw                 |    83.3%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/cluster/aws     |    72.4%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/databasecatalog |    66.7%
+ github.com/cloudera/terraform-provider-cdp/resources/environments       |    44.3%
+ github.com/cloudera/terraform-provider-cdp/resources/iam                |     2.8%
- github.com/cloudera/terraform-provider-cdp/resources/ml                 |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/opdb               |    25.3%
+ github.com/cloudera/terraform-provider-cdp/utils                        |    51.3%
+ github.com/cloudera/terraform-provider-cdp/utils/test                   |    68.8%

vcsomor
vcsomor previously approved these changes Oct 24, 2024
Copy link
Contributor

@vcsomor vcsomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general!
Thanks

resources/dw/catalog/resource_catalog.go Outdated Show resolved Hide resolved
resources/dw/catalog/resource_catalog.go Outdated Show resolved Hide resolved
resources/dw/catalog/resource_catalog.go Outdated Show resolved Hide resolved
resources/dw/catalog/resource_catalog.go Outdated Show resolved Hide resolved
resources/dw/catalog/resource_catalog.go Outdated Show resolved Hide resolved
resources/dw/catalog/schema_catalog.go Outdated Show resolved Hide resolved
@gregito
Copy link
Contributor

gregito commented Oct 24, 2024

@tevesz please rebase on master
cc: @vcsomor

@tevesz
Copy link
Contributor Author

tevesz commented Oct 25, 2024

Looks good in general! Thanks

@vcsomor thanks for the review! I've added the suggestions.

Adding creation and deletion options for the data warehouse catalog
object type.
@tevesz tevesz merged commit 7302a84 into main Oct 25, 2024
9 checks passed
@tevesz tevesz deleted the DWX-18781 branch October 25, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants