Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linter to standardize golang import order #175

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Add linter to standardize golang import order #175

merged 1 commit into from
Nov 6, 2024

Conversation

tevesz
Copy link
Contributor

@tevesz tevesz commented Nov 6, 2024

The gci linter is added to the default linter list. The make fix command if run manually can fix the import problems in the project.

The gci linter is added to the default linter list. The make fix command
if run manually can fix the import problems in the project.
@tevesz tevesz requested a review from a team as a code owner November 6, 2024 02:46
Copy link

github-actions bot commented Nov 6, 2024

Go test coverage: 33.6% for commit d97db57
⚠️ 2 of 14 packages have zero coverage.
  • github.com/cloudera/terraform-provider-cdp/resources/de
  • github.com/cloudera/terraform-provider-cdp/resources/ml
View coverage for all packages
# Package Name                                                                  | Coverage
+ github.com/cloudera/terraform-provider-cdp/cdpacctest                         |    26.9%
+ github.com/cloudera/terraform-provider-cdp/provider                           |    78.7%
+ github.com/cloudera/terraform-provider-cdp/resources/datahub                  |    36.3%
+ github.com/cloudera/terraform-provider-cdp/resources/datalake                 |     8.4%
- github.com/cloudera/terraform-provider-cdp/resources/de                       |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/cluster/aws           |    72.4%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/databasecatalog       |    66.7%
+ github.com/cloudera/terraform-provider-cdp/resources/dw/virtualwarehouse/hive |    74.3%
+ github.com/cloudera/terraform-provider-cdp/resources/environments             |    44.1%
+ github.com/cloudera/terraform-provider-cdp/resources/iam                      |     2.8%
- github.com/cloudera/terraform-provider-cdp/resources/ml                       |     0.0%
+ github.com/cloudera/terraform-provider-cdp/resources/opdb                     |    25.3%
+ github.com/cloudera/terraform-provider-cdp/utils                              |    55.3%
+ github.com/cloudera/terraform-provider-cdp/utils/test                         |    68.8%

Copy link
Contributor

@vcsomor vcsomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@daszabo daszabo merged commit b299e93 into main Nov 6, 2024
9 checks passed
@daszabo daszabo deleted the gci-linter branch November 6, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants