Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDPCP-9892 Update index.md #27

Merged
merged 3 commits into from
Nov 29, 2023
Merged

CDPCP-9892 Update index.md #27

merged 3 commits into from
Nov 29, 2023

Conversation

balazsgaspar
Copy link
Contributor

Updated the terraform provider docs

@balazsgaspar balazsgaspar requested a review from a team as a code owner July 11, 2023 12:50
enis
enis reviewed Jul 11, 2023
View reviewed changes
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
@enis
Copy link
Contributor

enis commented Aug 1, 2023

@balazsgaspar I've updated this PR by rebasing and applying some of my review comments and fixing some more minor issues. I hope you don't mind.

@gregito gregito self-requested a review August 7, 2023 13:38
gregito
gregito requested changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@gregito gregito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please assign it to a specific Jira ticket and mention it in both the commit message and the PR name. Thank you!

@gregito
Copy link
Contributor

gregito commented Nov 27, 2023

@balazsgaspar is this pr can be merged or closed?

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2023 •
edited
Loading

Go test coverage: 18.4% for commit cb62e59
⚠️ 2 of 8 packages have zero coverage.
  • github.com/cloudera/terraform-provider-cdp/resources/iam
  • github.com/cloudera/terraform-provider-cdp/resources/ml
View coverage for all packages 
# Package Name                                                      | Coverage
+ github.com/cloudera/terraform-provider-cdp/provider               |    78.7%
+ github.com/cloudera/terraform-provider-cdp/resources/datahub      |    27.0%
+ github.com/cloudera/terraform-provider-cdp/resources/datalake     |     2.7%
+ github.com/cloudera/terraform-provider-cdp/resources/environments |    17.0%
- github.com/cloudera/terraform-provider-cdp/resources/iam          |     0.0%
- github.com/cloudera/terraform-provider-cdp/resources/ml           |     0.0%
+ github.com/cloudera/terraform-provider-cdp/utils                  |    42.9%
+ github.com/cloudera/terraform-provider-cdp/utils/test             |    80.0%

@balazsgaspar balazsgaspar requested a review from gregito November 29, 2023 10:33
@gregito gregito enabled auto-merge (rebase) November 29, 2023 10:38
@gregito gregito merged commit a2ba886 into main Nov 29, 2023
6 checks passed
@balazsgaspar balazsgaspar deleted the tf-doc-updates branch November 29, 2023 11:05
@balazsgaspar balazsgaspar changed the title Update index.md CDPCP-9892 Update index.md Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enis enis enis left review comments

@gregito gregito gregito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balazsgaspar @enis @gregito