Remove SourceLink package reference #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With .NET 8, SourceLink is available by default. Fixes cloudevents#304. Signed-off-by: Jon Skeet <jonskeet@google.com>
captainsafia
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
Looks good!
While we're thinking about features we're taking advantage of in the .NET 8 SDK, should we update the globa.json to point to 8.0.400?
In case you're interested in automating this, there's a GitHub action we use on the ASP.NET Core repo to manage automatic updates.
|
Thanks - I'll create a new PR (and merge it) to update to 8.0.400, then look at setting up Renovate - that definitely handles global.json as well as other dependencies. (I assume it knows about Directory.Packages.props...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With .NET 8, SourceLink is available by default.
Fixes #304.
cc @captainsafia