-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch encoding support in bindings interfaces #301
Comments
After playing with the multipart experiment, i come out with
My proposal is that we should provide at bindings level this interface and in http protocol implement it for batch encoding. Then, we won't have any support for it at protocol level (and at client level) and we'll provide to users an example for using it (like https://github.com/slinkydeveloper/sdk-go/blob/multipart_experiment/v2/cmd/samples/http_multipart/random_multi_event_send/main.go). My problem with this plan is
|
I think I agree with a new So I can see this being implemented without an API breaking change on the surfaces we care about. |
support batch event now ? |
Really looking forward to be able to send multiple events at once. Can i help somehow to implement it? |
Simple implementations of NewEventsFromHTTPRequest and NewEventsFromHTTPResponse as a step towards providing some support for `application/cloudevents-batch+json`. This doesn't help with batch sending of Events, but this provides some basics of being able to process batch requests and/or responses from standard Go HTTP handling. This could be improved over time (See previous work on cloudevents#301) as well, but optimised for having something that works to start, rather than implementing big design changes. Signed-off-by: Mark Mandel <markmandel@google.com>
Simple implementations of NewEventsFromHTTPRequest and NewEventsFromHTTPResponse as a step towards providing some support for `application/cloudevents-batch+json`. This doesn't help with batch sending of Events, but this provides some basics of being able to process batch requests and/or responses from standard Go HTTP handling. This could be improved over time (See previous work on cloudevents#301) as well, but optimised for having something that works to start, rather than implementing big design changes. Signed-off-by: Mark Mandel <markmandel@google.com>
* http: Batch Events from HTTP Request and Response Simple implementations of NewEventsFromHTTPRequest and NewEventsFromHTTPResponse as a step towards providing some support for `application/cloudevents-batch+json`. This doesn't help with batch sending of Events, but this provides some basics of being able to process batch requests and/or responses from standard Go HTTP handling. This could be improved over time (See previous work on #301) as well, but optimised for having something that works to start, rather than implementing big design changes. Signed-off-by: Mark Mandel <markmandel@google.com> * Implement NewHTTPRequestFromEvents Now you can send batch events with your very own http.Client. Signed-off-by: Mark Mandel <markmandel@google.com> * Review updates * Expanded test for NewEventsFromHTTPRequest * Implemented NewHTTPRequestFromEvent as well Signed-off-by: Mark Mandel <markmandel@google.com> * Add IsHTTPBatch IsHTTPBatch is a convenience function such that an end user could determine if a request or response is batch or not, and process it as such. Signed-off-by: Mark Mandel <markmandel@google.com> * Review updates * Reorder in alias.go * More coverage of TestNewEventsFromHTTPRequest * tests for `to_events(...)` * Better comment documentation. Signed-off-by: Mark Mandel <markmandel@google.com> Signed-off-by: Mark Mandel <markmandel@google.com>
No description provided.
The text was updated successfully, but these errors were encountered: