Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the mqtt sdk from v0.12.0 to v0.21.0 #1096

Merged
merged 2 commits into from
Sep 21, 2024

Conversation

yanmxa
Copy link
Contributor

@yanmxa yanmxa commented Sep 11, 2024

Signed-off-by: myan myan@redhat.com

Signed-off-by: myan <myan@redhat.com>
@yanmxa yanmxa requested a review from a team as a code owner September 11, 2024 15:14
@yanmxa yanmxa changed the title Bump the mqtt sdk to v0.21.0 Bump the mqtt sdk from v0.12.0 to v0.21.0 Sep 11, 2024
Signed-off-by: myan <myan@redhat.com>
@embano1
Copy link
Member

embano1 commented Sep 15, 2024

Quick question: in our README we say

Note: Supported go version: 1.18+

I'm assuming the bump to v1.21 here is due to the dependency also requiring it?

@yanmxa
Copy link
Contributor Author

yanmxa commented Sep 18, 2024

Quick question: in our README we say

Note: Supported go version: 1.18+

I'm assuming the bump to v1.21 here is due to the dependency also requiring it?

Yes. The sdk requires a higher go version.

Do we plan to upgrade the go version?

@embano1
Copy link
Member

embano1 commented Sep 21, 2024

Yeah, we should bump our min modules version. So going to merge this one.

@embano1 embano1 enabled auto-merge September 21, 2024 07:43
@embano1 embano1 merged commit fe89b81 into cloudevents:main Sep 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants