Fix segfault if ce-specversion header missing #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestona
force-pushed
the
no-specversion-segfault
branch
from
7047d51 to
ca38263
Compare
If a HTTP request does not contain the `ce-specversion` header then the process of converting the request to an event returns a `nil` event and a non-fatal error value. Unfortunately, in this situation, the code continued to process the request resulting in an attempt to de-reference the `nil` event value. Fix by adding an additional condition to the error handling. Now conversions that yield a non-fatal error must also return a non-nil event, otherwise a HTTP 400 (Bad Request) status is returned. Signed-off-by: Adrian Preston <prestona@uk.ibm.com>
prestona
force-pushed
the
no-specversion-segfault
branch
from
ca38263 to
08fcb4f
Compare
|
oh nice catch! /lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a HTTP request does not contain the
ce-specversionheader then theprocess of converting the request to an event returns a
nilevent and a non-fatal error value. Unfortunately, in this situation,
the code continued to process the request resulting in an attempt to
de-reference the
nilevent value.Fix by adding an additional condition to the error handling. Now
conversions that yield a non-fatal error must also return a non-nil
event, otherwise a HTTP 400 (Bad Request) status is returned.