Fix a race condition in the distributed tracing unit tests #420
+42
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix the following bugs which were uncovered as a result: 1. The sampled flag would not be correctly set when creating SpanContext 2. Tracestate parsing would fail and be omitted from SpanContext Signed-off-by: Ian Milligan <ianmllgn@gmail.com>
ian-mi
force-pushed
the
distributed-tracing-parsing-fixes
branch
from
5fd0a9c to
220102a
Compare
|
LGTM |
ian-mi
added a commit
to ian-mi/sdk-go
that referenced
this pull request
Apr 16, 2020
…ts#420) Also fix the following bugs which were uncovered as a result: 1. The sampled flag would not be correctly set when creating SpanContext 2. Tracestate parsing would fail and be omitted from SpanContext Signed-off-by: Ian Milligan <ianmllgn@gmail.com>
n3wscott
pushed a commit
that referenced
this pull request
Apr 16, 2020
Also fix the following bugs which were uncovered as a result: 1. The sampled flag would not be correctly set when creating SpanContext 2. Tracestate parsing would fail and be omitted from SpanContext Signed-off-by: Ian Milligan <ianmllgn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix the following bugs which were uncovered as a result:
SpanContext