Data race fix in client #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
slinkydeveloper
force-pushed
the
data_race
branch
from
ad02c02 to
1144284
Compare
|
@n3wscott I disabled the pubsub test because it's preventing this pr to be merged. Since this fix is important, i propose to leave it disabled and fix in a follow up. Do you have any input on why the pubsub test fail? On my machine they run smoothly, but CI doesn't like them, and doesn't log why https://circleci.com/gh/cloudevents/sdk-go/1138 |
|
that is very weird. File an issue and we can give it to the pubsub maintainers to look at. LGTM |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two data races in client:
GetPortfor getting the actual port was racy because another goroutine is starting the listening.GetPortnow is renamed withGetListeningPortfor clarity and the internalnet.Listeneris behind an atomic.ValueEnabled data race check in CI