Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to construct mock sender for unit testing #564

Merged
merged 2 commits into from
Aug 3, 2020

Conversation

aslom
Copy link
Contributor

@aslom aslom commented Jul 30, 2020

Add NewSenderFromSyncProducer to allow running unit tests with mock sender form outside SDK

@slinkydeveloper
Copy link
Member

can you rebase on master?

aslom added 2 commits July 31, 2020 09:12
Signed-off-by: Aleksander Slominski <aslom@us.ibm.com>
Signed-off-by: Aleksander Slominski <aslom@us.ibm.com>
@aslom aslom force-pushed the mock_tests_support branch from 683ef4a to 5ea473a Compare July 31, 2020 13:13
@aslom
Copy link
Contributor Author

aslom commented Jul 31, 2020

Following https://github.com/cloudevents/sdk-go/blob/master/pr_guidelines.md#submitting-and-updating-your-pull-request

I have ran

git fetch upstream
git rebase upstream/master
git push -f origin mock_tests_support
git rebase -i upstream/master
git push -f origin mock_tests_support

@slinkydeveloper
Copy link
Member

Thank you for the contribution!

@slinkydeveloper slinkydeveloper merged commit 269a447 into cloudevents:master Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants