HTTP Protocol: add RequestData in Context option. #747
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #742
@n3wscott this is not implemented exactly as described in the issue.
Instead of adding it at the ServeHTTP method this PR leverages the http.Options, so this feature is an opt-in.
My main concern is that requests will hit the middleware prior to the
RateLimiter
which feels like the wrong order, but that's the case for all middlewares here. I don't consider that an issue in this PR and if we were to improve the pattern I would suggest moving theRateLimiting
feature also as an option (in a different PR).