Add ReadHeaderTimeout for security #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duglin
force-pushed
the
issue821
branch
5 times, most recently
from
54d75c1 to
ca9aea8
Compare
|
ping @lionelvillard |
embano1
reviewed
Dec 9, 2022
| Handler: attachMiddleware(p.Handler, p.middleware), | ||
| Addr: listener.Addr().String(), | ||
| Handler: attachMiddleware(p.Handler, p.middleware), | ||
| ReadHeaderTimeout: DefaultReadTimeout, |
There was a problem hiding this comment.
Question: How about we fix it for both read/write? Or at least set ReadTimeout instead of just for headers to protect the read path?
There was a problem hiding this comment.
Good point - I'll do both (read and write) and do the entire thing, not just headers
Closes cloudevents#821 Signed-off-by: Doug Davis <dug@microsoft.com>
|
@lionelvillard wanna review this one? |
|
@lionelvillard @embano1 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #821
Signed-off-by: Doug Davis dug@microsoft.com