Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine error message when validating extension name #845

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

jackedelic
Copy link
Contributor

No description provided.

Copy link

@zzxwill zzxwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jackedelic jackedelic force-pushed the fix-error-message branch 2 times, most recently from 337bf14 to 4ff0930 Compare February 17, 2023 02:40
Signed-off-by: jack.wong <jack.wong@bytedance.com>
@lionelvillard lionelvillard merged commit 79ffd85 into cloudevents:main Feb 21, 2023
nbajaj90 pushed a commit to nbajaj90/sdk-go that referenced this pull request Mar 15, 2023
Signed-off-by: jack.wong <jack.wong@bytedance.com>
Co-authored-by: jack.wong <jack.wong@bytedance.com>
Signed-off-by: nbajaj90 <nbajaj90@gmail.com>
nbajaj90 added a commit to nbajaj90/sdk-go that referenced this pull request Mar 15, 2023
nbajaj90 pushed a commit to nbajaj90/sdk-go that referenced this pull request Mar 15, 2023
Signed-off-by: jack.wong <jack.wong@bytedance.com>
Co-authored-by: jack.wong <jack.wong@bytedance.com>
Signed-off-by: nbajaj90 <nbajaj90@gmail.com>
nbajaj90 added a commit to nbajaj90/sdk-go that referenced this pull request Mar 15, 2023
…nts#845)"

This reverts commit 005748c.

Signed-off-by: nbajaj90 <nbajaj90@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants