Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add assertion helper for extension keys #920

Merged
merged 4 commits into from
Jul 17, 2023

Conversation

yanmxa
Copy link
Contributor

@yanmxa yanmxa commented Jul 14, 2023

resolved: #900

@yanmxa yanmxa force-pushed the br_assert branch 2 times, most recently from 81e4db0 to 91d4c02 Compare July 14, 2023 08:55
Signed-off-by: myan <myan@redhat.com>
yanmxa added 2 commits July 14, 2023 09:05
Signed-off-by: myan <myan@redhat.com>
Signed-off-by: myan <myan@redhat.com>
@@ -184,6 +184,18 @@ func HasExtensions(ext map[string]interface{}) EventMatcher {
}
}

// HasExtensionKeys checks if the event contain the provided keys from its extensions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit "contains"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@embano1 Done~

Signed-off-by: myan <myan@redhat.com>
Copy link
Member

@embano1 embano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duglin
Copy link
Contributor

duglin commented Jul 17, 2023

LGTM

ping @lionelvillard for the merge

@lionelvillard lionelvillard merged commit e15d03d into cloudevents:main Jul 17, 2023
@yanmxa yanmxa deleted the br_assert branch July 18, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test.HasExtensionsKeys assertion helper
4 participants