-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add assertion helper for extension keys #920
Conversation
81e4db0
to
91d4c02
Compare
Signed-off-by: myan <myan@redhat.com>
Signed-off-by: myan <myan@redhat.com>
Signed-off-by: myan <myan@redhat.com>
v2/test/event_matchers.go
Outdated
@@ -184,6 +184,18 @@ func HasExtensions(ext map[string]interface{}) EventMatcher { | |||
} | |||
} | |||
|
|||
// HasExtensionKeys checks if the event contain the provided keys from its extensions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit "contains"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@embano1 Done~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM ping @lionelvillard for the merge |
resolved: #900