context.Done() may never reach if waiting on r.incoming <- msgErr #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nbajaj90 <nbajaj90@gmail.com>
nbajaj90
force-pushed
the
unblock_context_done
branch
from
99a3dd0 to
6aa2742
Compare
embano1
reviewed
Sep 13, 2023
| select { | ||
| case r.incoming <- msgErrObj: | ||
| // do nothing | ||
| case <-session.Context().Done(): |
There was a problem hiding this comment.
spot on! usually we'd return session.Context.Err() to let the caller know why the function returned. But this would break the existing behavior (returning nil). A user could always use context.Cause(ctx), but that might not be intuitive from the nil behavior.
Anyways, IMHO with this change you can remove the code in line 95?
There was a problem hiding this comment.
Code on line 95 is still required. If code on line no. 64 case msg, ok := <-claim.Messages(): doesn't get hit, that code on line no. 95 would exit the flow.
There was a problem hiding this comment.
True, was under the assumption that ok would be false due to propagated channel somewhere into Sarama...but seems that's not the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While analysing an issue, we observed that even after context is cancelled, the code was blocked in ConsumeClaim. And the reason is if the code if blocked at r.incoming <- msgErr, it may fail to honour or may skip the outside session.Context().Done().
Reference - https://stackoverflow.com/questions/67608032/context-ctx-done-not-being-executed-even-though-context-was-passed-to-the-functi
Solution is to add session.Context().Done() with r.incoming <- msgErr in select clause.