Skip to content

Commit

Permalink
feat!: remove node 12 and node 14 (#545)
Browse files Browse the repository at this point in the history
* feat!: remove node 12 and node 14

Node 12 has been EOL since the end of April 2022 and Node 14 just became EOL at the end of April 2023

Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
  • Loading branch information
lholmquist authored May 3, 2023
1 parent 4626529 commit 2cb9364
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/nodejs-ci-action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [12.x, 14.x, 16.x, 18.x]
node-version: [16.x, 18.x, 20.x]

steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,6 @@
},
"types": "./dist/index.d.ts",
"engines": {
"node": ">=12 <=20.0.0"
"node": ">=16 <=20.0.0"
}
}
2 changes: 1 addition & 1 deletion test/integration/parser_test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ describe("JSON Event Format Parser", () => {
const parser = new Parser();

// TODO: Should the parser catch the SyntaxError and re-throw a ValidationError?
expect(parser.parse.bind(parser, payload)).to.throw(SyntaxError, "Unexpected token g in JSON at position 1");
expect(parser.parse.bind(parser, payload)).to.throw(SyntaxError);
});

it("Accepts a string as valid JSON", () => {
Expand Down

0 comments on commit 2cb9364

Please sign in to comment.