squash: can pass in an Object now

Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
cloudevents · Jul 24, 2020 · 4365f47 · 4365f47
1 parent 194cdf3
commit 4365f47
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/event/validation.ts b/src/event/validation.ts
@@ -82,4 +82,4 @@ export const asData = (data: unknown, contentType: string): string => {
 };
 
 export const isValidType = (v: boolean | number | string | Date | Uint32Array | unknown): boolean =>
-  isBoolean(v) || isInteger(v) || isString(v) || isDate(v) || isBinary(v);
+  isBoolean(v) || isInteger(v) || isString(v) || isDate(v) || isBinary(v) || isObject(v);
diff --git a/test/integration/spec_1_tests.ts b/test/integration/spec_1_tests.ts
@@ -87,10 +87,8 @@ describe("CloudEvents Spec v1.0", () => {
       expect(cloudevent.cloneWith({ extdate: myDate }).validate()).to.equal(true);
     });
 
-    it("should fail when the type is an object", () => {
-      expect(() => {
-        cloudevent.cloneWith({ objectextension: { some: "object" } });
-      }).to.throw(ValidationError, "invalid extension value");
+    it("should be ok when the type is an object", () => {
+      expect(cloudevent.cloneWith({ objectextension: { some: "object" } }).validate()).to.equal(true);
     });
 
     it("should be ok when the type is an string converted from an object", () => {