Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

develop branch and npm package behind #12

Closed
csantanapr opened this issue May 24, 2019 · 2 comments
Closed

develop branch and npm package behind #12

csantanapr opened this issue May 24, 2019 · 2 comments

Comments

@csantanapr
Copy link

There are 2 PRs that are already merged.

PR #10 Changed JSON schema validator's options to remove warning: "$ref: key…

  • is in the develop branch, not in master or released in npm registry

PR #8 Added missing 'source' getter on Spec02

  • is in master branch but not released on npm registry

Can this 2 fixes be promoted to the npm registry?

Also trunk based development working on master branch seems to be more productive and adopted this days, why not just have 1 branch master?

@csantanapr
Copy link
Author

For anyone hitting the same problem I created a branch with develop merged in master here is what to put in your package.json

{
  "dependencies": {
    "cloudevents-sdk": "csantanapr/cloudevents-sdk-javascript#tempfix-12",
  }
}

@fabiojose
Copy link
Contributor

@csantanapr sorry about this little mess!

Now, the things are good again!

https://www.npmjs.com/package/cloudevents-sdk/v/0.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants