Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing 'source' getter on Spec02 #8

Merged
merged 3 commits into from
Apr 18, 2019
Merged

Added missing 'source' getter on Spec02 #8

merged 3 commits into from
Apr 18, 2019

Conversation

micheleangioni
Copy link
Contributor

Hi,

on the Spec02 object a getter for the source attribute is missing.
The Spec01 object has it, so I added it also in the new version.

Best

Signed-off-by: Michele Angioni <michele.angioni@takeaway.com>
@micheleangioni
Copy link
Contributor Author

Tests are passing, but the coverage is failing.

@hechi
Copy link

hechi commented Mar 19, 2019

hmmm... seams that the CODADY_PROJECT_TOKEN is not set probably @fabiojose could help us?

@fabiojose
Copy link
Contributor

Hello folks! I will check that problem.

@fabiojose
Copy link
Contributor

@micheleangioni, please replace the entry in env.global with below and push again! This entry is in .travis.yaml.

secure: "GgLsminwitZCtFwRkijoF03uz0+jA+jayrWyvkFfipND8S7KkmcY6iqBjBkA/ZNkvh2jgwD3fG7Jp6f795Oyb6oq8u/xF7h446YcG4FPye1v6abWhKLaOQrcTca++xl6Ph6sHRRwaV2dw/UIRRHikJWZEIKS2jgAkQ1dW7srMJhIWTIegDYYpj3c1Ri2wL5S9799zyO/c12JLpawxQvzhEG2YyYkdEI0H/9HsUezoBrCZdxjVb/LAa0nUTmQiAfX4CYRHidU4QCbznQhHWFdGr/9wKvy1dyCxAWLosWSy+mIq3teeCJ80c/Yi+yEv96tg5wL75shfYzx4JMSL6YIyfF6OrbAM0jYGIMJdf/UEG1TKNpRnIqugnCJbdjZpn6mavrayjnaq9KSc7wgXBXox5jucfWLDfV2LZ18qfqHIeubIT7X69k8P5M4z4MU3YR3mqiZtEy6CPi+h0ReMLheFKemAmHWSL4zV1YfBRFVyFP0LM4Qsi4UVtCJQUHwvjNcO2ZUXLe6OzqXN987JKwTOyecmn9s/24UDofBxuMqTWYTssKPI0bHpOiWCqd5ml9Uz1/5o6bjGhvbJjv1K/0xWS2PoWim/RSnNTNi+en+GgEKuaDZkCktHVOKg7xkpsW0DvtcpwVQRdyXUN1s2h+EHgSBuoeAo4fhbXRUVsu5zuY="

Signed-off-by: Michele Angioni <michele.angioni@takeaway.com>
@micheleangioni
Copy link
Contributor Author

Hi @fabiojose , thanks for your answer. I have tried to do as you said (I updated the .travis.yml file), but I get the same error..

@fabiojose
Copy link
Contributor

Good, let's remove the script: npm run coverage for now.
Please remove the command above in .travis.yml and push again.

@micheleangioni thanks for you patience.

@fabiojose fabiojose closed this Apr 9, 2019
@fabiojose fabiojose reopened this Apr 9, 2019
Signed-off-by: Michele Angioni <michele.angioni@takeaway.com>
@micheleangioni
Copy link
Contributor Author

@fabiojose I have updated the PR :)

@fabiojose fabiojose merged commit 7bf109a into cloudevents:master Apr 18, 2019
@cwallsfdc
Copy link

Publish this change to npm? @fabiojose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants