Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add usage examples to README for HTTPReciever and CloudEvent #128

Closed
lance opened this issue May 5, 2020 · 0 comments · Fixed by #138
Closed

Add usage examples to README for HTTPReciever and CloudEvent #128

lance opened this issue May 5, 2020 · 0 comments · Fixed by #138
Assignees
@lance
Labels
module/docs Module documentation changes module/releases Pertaining to releases of the module

Comments

@lance
Copy link
Member

lance commented May 5, 2020

The API has changed a bit, and while the places it has changed are not provided as examples in the README, the changes are notable improvements and should be documented.

Ref: #127
@lance lance added module/docs Module documentation changes module/releases Pertaining to releases of the module labels May 5, 2020
@lance lance self-assigned this May 5, 2020
@lance lance mentioned this issue May 7, 2020
Closed
lance added a commit to lance/sdk-javascript that referenced this issue May 8, 2020
@lance
docs: update README and examples with new API
424cfb0 
This commit modifies the README to show new API usage for the
`HTTPReceiver` and `CloudEvent` classes, and updates the examples
to use this as well.

Fixes: cloudevents#128

Signed-off-by: Lance Ball <lball@redhat.com>
@lance lance mentioned this issue May 8, 2020
Merged
lance added a commit to lance/sdk-javascript that referenced this issue May 9, 2020
@lance
docs: update README and examples with new API
1888d07 
This commit modifies the README to show new API usage for the
`HTTPReceiver` and `CloudEvent` classes, and updates the examples
to use this as well.

Overall structure and content has been modified to look more like
the sdk-go README.

Fixes: cloudevents#128

Signed-off-by: Lance Ball <lball@redhat.com>
lance added a commit to lance/sdk-javascript that referenced this issue May 9, 2020
@lance
docs: update README and examples with new API
ff5d965 
This commit modifies the README to show new API usage for the
`HTTPReceiver` and `CloudEvent` classes, and updates the examples
to use this as well.

Overall structure and content has been modified to look more like
the sdk-go README.

Fixes: cloudevents#128

Signed-off-by: Lance Ball <lball@redhat.com>
lance added a commit that referenced this issue May 11, 2020
@lance
docs: update README and examples with new API (#138)
b866edd 
This commit modifies the README to show new API usage for the
`HTTPReceiver` and `CloudEvent` classes, and updates the examples
to use this as well.

Overall structure and content has been modified to look more like
the sdk-go README.

Fixes: #128

Signed-off-by: Lance Ball <lball@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lance lance

Labels
module/docs Module documentation changes module/releases Pertaining to releases of the module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: update README and examples with new API lance/sdk-javascript
1 participant
@lance