Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receiver.accept() should sanitize headers #237

Closed
lance opened this issue Jul 2, 2020 · 0 comments · Fixed by #239
Closed

Receiver.accept() should sanitize headers #237

lance opened this issue Jul 2, 2020 · 0 comments · Fixed by #239
Labels
type/bug Something isn't working

Comments

@lance
Copy link
Member

lance commented Jul 2, 2020

Most of the time users will be using the Receiver in some sort of web framework that automatically sanitizes headers before user code accesses them. That's not always the case, though. Because the Receiver.acccept() method doesn't sanitize, it won't be able to detect a structured event if the content type header is Content-Type instead of content-type.

https://github.com/cloudevents/sdk-javascript/blob/master/src/transport/receiver.ts#L62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant