Skip to content

Conversation

lance
Copy link
Member

@lance lance commented Jul 3, 2020

Even though the underlying structured and binary receivers already sanitize
the headers, this needs to be done at the receiver.accept() level since
the headers are inspected there to determine what mode the event is being
sent as.

Fixes: #237

Signed-off-by: Lance Ball lball@redhat.com

Even though the underlying structured and binary receivers already sanitize
the headers, this needs to be done at the receiver.accept() level since
the headers are inspected there to determine what mode the event is being
sent as.

Signed-off-by: Lance Ball <lball@redhat.com>
@lance lance added the type/bug Something isn't working label Jul 3, 2020
@lance lance requested a review from a team July 3, 2020 14:08
@lance lance self-assigned this Jul 3, 2020
@lance lance requested review from danbev, fabiojose and grant and removed request for a team July 3, 2020 14:08
Signed-off-by: Lance Ball <lball@redhat.com>
@lance lance requested review from helio-frota and lholmquist July 3, 2020 15:21
@lance
Copy link
Member Author

lance commented Jul 6, 2020

Ping @cloudevents/sdk-javascript-maintainers PTAL

@lance lance merged commit 51035dc into cloudevents:master Jul 6, 2020
@lance lance mentioned this pull request Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Receiver.accept() should sanitize headers

2 participants