Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.1.0 #300

Closed
lholmquist opened this issue Aug 4, 2020 · 12 comments
Closed

Release 3.1.0 #300

lholmquist opened this issue Aug 4, 2020 · 12 comments
Labels
module/releases Pertaining to releases of the module version/3.x Issues related to the 3.0 release of this library

Comments

@lholmquist
Copy link
Contributor

3.0.1 was released the 29th of August, but we also forgot to update the browser version to the new name. The commits below include that update. Should we release a new patch release soon with that change? I don't think there are any commits below that need a minor bump. I can see an argument for a7e0aa0 as a minor bump, but I don't think it needs to be

git log v3.0.1..origin/master --oneline

a7e0aa0 lib: expose constants in a more intuitive way (#299)
bc81242 build(deps): bump elliptic from 6.5.2 to 6.5.3 (#290)
31c2005 refactor: no import star (#297)
48d182b fix: update browser name to cloudevents. (#292)
763838c chore: Update examples to use latest sdk changes (#282)
3fab5f2 docs: update badge name (#289)
ed9ea95 fix: ensure that data encoded as base64 is parsed as an object (#285)
e219a30 chore: Update readme with correct Receiver usage (#287)
@lholmquist lholmquist added module/releases Pertaining to releases of the module version/3.x Issues related to the 3.0 release of this library labels Aug 4, 2020
@lance
Copy link
Member

lance commented Aug 5, 2020

3.0.1 was released the 29th of August

That's some powerful time machine work you've got there! 😆

@lance
Copy link
Member

lance commented Aug 5, 2020

+1 for a new release

@lholmquist
Copy link
Contributor Author

That's some powerful time machine work you've got there! laughing

🤦

@lance
Copy link
Member

lance commented Aug 5, 2020

@lholmquist thinking a bit more about this, I think maybe this warrants a 3.1.0 release. The change with CONSTANTS being exported is a breaking change, and will actually break an automated upgrade.

@lholmquist
Copy link
Contributor Author

@lance that is fine.

@lholmquist lholmquist changed the title Release 3.0.2 Release 3.1.0 Aug 6, 2020
@lholmquist
Copy link
Contributor Author

lets make sure this makes it in too, #302

@lholmquist
Copy link
Contributor Author

lholmquist commented Aug 7, 2020

Updating the list of commits:

git log v3.0.1..origin/master --oneline

a5249de chore: fix promise tests to break the build when they fail (#305)
ad0c434 fix: Add Correct Headers to emitted Binary Event (#302)
a7e0aa0 lib: expose constants in a more intuitive way (#299)
bc81242 build(deps): bump elliptic from 6.5.2 to 6.5.3 (#290)
31c2005 refactor: no import star (#297)
48d182b fix: update browser name to cloudevents. (#292)
763838c chore: Update examples to use latest sdk changes (#282)
3fab5f2 docs: update badge name (#289)
ed9ea95 fix: ensure that data encoded as base64 is parsed as an object (#285)
e219a30 chore: Update readme with correct Receiver usage (#287)

@lholmquist
Copy link
Contributor Author

So doing a npm run release -- --dry-run the version that was created, was 3.0.2 based on the commits.

@lance @grant I think we might need to force a 3.1.0 if we feel #299 makes it a minor bump instead of a patch bump

@lance
Copy link
Member

lance commented Aug 10, 2020

@lholmquist I think we should... You may know how already, but it's pretty easy to force a version number.

npm run release -- --release-as 3.2.0

@lholmquist
Copy link
Contributor Author

yup, i am familiar

@lholmquist
Copy link
Contributor Author

lholmquist commented Aug 11, 2020

There have been a couple commits that came in today, which were doc and some process related things, 3.1.0 is now looking like:

d590e3a docs: improve readme receiver example (#309)
08bf15d docs: Release Guidelines (#306)
f3cc2b4 chore: update the release script to signoff the commit (#307)
a5249de chore: fix promise tests to break the build when they fail (#305)
ad0c434 fix: Add Correct Headers to emitted Binary Event (#302)
a7e0aa0 lib: expose constants in a more intuitive way (#299)
bc81242 build(deps): bump elliptic from 6.5.2 to 6.5.3 (#290)
31c2005 refactor: no import star (#297)
48d182b fix: update browser name to cloudevents. (#292)
763838c chore: Update examples to use latest sdk changes (#282)
3fab5f2 docs: update badge name (#289)
ed9ea95 fix: ensure that data encoded as base64 is parsed as an object (#285)
e219a30 chore: Update readme with correct Receiver usage (#287)

@lholmquist
Copy link
Contributor Author

Released now as 3.1.0, https://www.npmjs.com/package/cloudevents/v/3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/releases Pertaining to releases of the module version/3.x Issues related to the 3.0 release of this library
Projects
None yet
Development

No branches or pull requests

2 participants