Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add Correct Headers to emitted Binary Event #302

Merged

Conversation

lholmquist
Copy link
Contributor

@lholmquist lholmquist commented Aug 5, 2020

This changes the header of the emitted Binary Event to be the correct header

Description

Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
@lholmquist lholmquist changed the title squash: update test to fail fix: Add Correct Headers to emitted Binary Event Aug 5, 2020
fixes cloudevents#301

Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
@lholmquist lholmquist force-pushed the 301-emit-binary-receive-structured branch from 54bdd56 to 51c67e3 Compare August 5, 2020 22:34
@lholmquist lholmquist marked this pull request as ready for review August 5, 2020 22:36
@lholmquist lholmquist requested review from lance and grant August 5, 2020 22:37
Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
@lholmquist lholmquist mentioned this pull request Aug 6, 2020
@lholmquist lholmquist merged commit ad0c434 into cloudevents:master Aug 6, 2020
@lholmquist lholmquist deleted the 301-emit-binary-receive-structured branch August 6, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants